Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328850

Summary: BestMatchHover needs to support ITextHoverExtension2
Product: [WebTools] JSDT Reporter: Michael Rennie <Michael_Rennie>
Component: GeneralAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact: Nitin Dahyabhai <thatnitind>
Severity: normal    
Priority: P3 CC: azerr
Version: 3.3Flags: thatnitind: review+
Target Milestone: 3.3 M3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 313015    
Attachments:
Description Flags
proposed fix none

Description Michael Rennie CLA 2010-10-27 11:46:08 EDT 
Created attachment 181848 [details]
proposed fix

code from HEAD

While trying to fix bug 313015, I found that I cannot return an Object to open a hover control on like we did for JDT. The reason for this is that BestMatchHover /AbstractJavaEditorTextHover (the JavaScript variant) does not support ITextHoverExtension2.

The attached patch adds support to the JS hovers for ITextHoverExtension2 (and allows the fix for bug 313015 to work)
Comment 1 Nitin Dahyabhai CLA 2010-10-27 13:24:36 EDT 
Sounds like a nice addition.
Comment 2 Michael Rennie CLA 2010-11-01 14:04:33 EDT 
applied patch to HEAD
Comment 3 Angelo ZERR CLA 2015-09-23 12:05:23 EDT 
I don't understand, it seems that current JSDT version doesn't support ITextHoverExtension2 . If you see http://git.eclipse.org/c/jsdt/webtools.jsdt.git/tree/bundles/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/ui/text/java/hover/AbstractJavaEditorTextHover.java this class doesn't implement ITextHoverExtension2  although this issue fix that?

In my case I need that for tern.java because without this support, the tern hover popup is too small.

Many thanks's for your help.