Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328842

Summary:	about.html for xerces-2.9.0 incorrectly refers to Apache-1.1 license for resolver.jar
Product:	[Tools] Orbit	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	bundles	Assignee:	David Williams <david_williams>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	david_williams
Version:	unspecified
Target Milestone:	Indigo M4
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Martin Oberhuber

2010-10-27 11:14:33 EDT

The about.html that Orbit / Eclipse ships for xerces-2.9.0:

http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.orbit/org.apache.xerces/about.html?revision=1.2.2.4&root=Tools_Project&pathrev=v2_9_0

refers to a file "resolver.jar" as being under Apache-1.1 license. But this appears to be incorrect for the following reasons:

1. Since xerces-2.9, resolver is packaged as a separate jar in Orbit. In fact,
   the related org.apache.xml.resolver_1.2.0.v201005080400.jar carries its
   own about.html file which refers to Apache-2.0 license.

2. The original Xerces-2.9.0 source code from
   http://archive.apache.org/dist/xml/xerces-j/Xerces-J-src.2.9.0.zip
   also has a LICENSE.resolver.txt showing Apache-2.0 license

It looks like the about.html for Xerces was copied from an older version, and the section referring to resolver.jar (which used to be bundled inside the Xerces bundle) was not removed as it should have been.

Comment 1 Martin Oberhuber

2010-10-27 11:17:38 EDT

In fact, it looks like the text referring to "xml-apis.jar", "xercesImpl.jar" is also not quite correct since these are distributed in their own bundles.

Comment 2 David Williams

2010-11-02 22:39:45 EDT

I think you are right some stuff from old xerces bundle was left here, and I think the easiest/best fix is to refresh all the "license" type files in "about_files" directory with new content from fresh xerces 2.9.0 zip download. 

And, fix the "1.1" reference in about.html to the correct "2.0". 

I am reluctant though to break up or leave out the individual jar info. While its true we break them up into separate bundles, we get them as one package, so it make some sense to "leave it as we got it". Seems more in the spirit of their distribution, and when it comes to xerces, pretty much have to use all those bundles along with Xerces. 

Make sense? Happy with that? I'll commit change to HEAD (well, head of the 2.9.0 branch), if you want to look first, before I release to a build.

Comment 3 Martin Oberhuber

2010-11-02 23:27:13 EDT

I see your point about "leave it as we got it" for the xerces bundle. 

Looking at the changes you made, I believe that the copy of "...must include the following disclaimer" in about.html is also still a left-over of the Apache 1.1 license which is also not included in the xml.resolver's about.

Following your thought about "leave it as we got it", should the about.html for xml.resolver mention that it was obtained as part of xerces? At the moment, it looks like xml.resolver was obtained individually, since the information in there goes beyond what xerces (eg where source can be obtained, a fact that I like).

http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.orbit/org.apache.xml.resolver/about.html?view=markup&revision=1.1.4.5&root=Tools_Project&pathrev=v1_2_0

Comment 4 David Williams

2010-11-03 00:01:06 EDT

> 
> ... believe that the copy of "...must include
> the following disclaimer" in about.html is also still a left-over 

good point. I removed that whole "specifically ... " section. It appears it (originally) just repeats what is in license, and we don't seem to do that repetition elsewhere, that I could see. 

> ... should the about.html for
> xml.resolver mention that it was obtained as part of xerces? 

I don't think so. I don't think it's wrong the way it is. And while maybe it and many about.html files could be made better ... I also think its important not to change things unless there's a substantial need to. 

Thanks again.