Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328819

Summary:	[Webapp] Help link with contents doesnt work if topic location has whitespace in it
Product:	[Eclipse Project] Platform	Reporter:	mkaditya <amadduri>
Component:	User Assistance	Assignee:	platform-ua-inbox <platform-ua-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	amadduri, cgold
Version:	3.5
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description mkaditya

2010-10-27 09:04:49 EDT

Build Identifier: I20090611-1540

Create a toc.xml which has location of the file having ws in it. 
Observe that link with contents in eclipse help doesn't work.

May be the problem is with URL encoding.

Reproducible: Always

Steps to Reproduce:
1.Create a toc in which topic has location path having whitespace
2.Observe that link with contents doesn't work for such topics in eclipse help contents.

Comment 1 Chris Goldthorpe

2010-11-09 19:33:44 EST

I was not able to reproduce this after creating a plug-in with help content and modifying some of the paths to contain spaces. Can you attach a small test plugin which illustrates the problem?

Comment 2 Chris Goldthorpe

2010-12-08 18:19:56 EST

Hello, are you still seeing the problem, if so can you submit a plug-in which illustrates the issue?

Comment 3 mkaditya

2010-12-09 04:39:41 EST

(In reply to comment #2)
> Hello, are you still seeing the problem, if so can you submit a plug-in which
> illustrates the issue?

There is no problem with WS if the provided URL is not encoded. However if the URL is encoded the functionality breaks.

Example toc.xml is:-

<toc label="Sample Table of Contents">
	<topic label="Main Topic"  href="html/ws%20folder/maintopic.html"> 
		<topic label="Sub Topic" href="html/ws%20folder/subtopic.html"/>
		<topic href="html/ws%20folder/toc%20with%20ws.html" label="WS Topic"> 
	</topic>
 </topic>
</toc>


My guess is we are doing the URL encoding to the already encoded URL.

Hope this helps.

Comment 4 Chris Goldthorpe

2010-12-09 12:30:54 EST

Yes, that does help, this is as designed, the help system will encode the hrefs in the table of contents so you should not encode them yourself.