Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328809

Summary: Polish new workspace configuration option for launch configurations
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, darin.eclipse
Version: 3.7Flags: curtis.windatt.public: review+
Target Milestone: 3.7 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 331612    
Attachments:
Description Flags
Fix
none
Fix 2
none
Updated patch with pref page fix
none
Improved labels none

Description Dani Megert CLA 2010-10-27 06:52:02 EDT 
I20101025-1800.

The new workspace configuration option for launch configurations needs some polish.

- It looks strange that I can choose the default workspace location for JUnit 
  but not for Eclipse launch configurations.
- I tried to get rid of the "runtime-" prefix by typing into the name field
  but no luck.
- On the launch config page we should add a link to the preference page.
- It's somewhat strange that typing in the name field updates the Eclipse
  workspace location but not the JUnit one (one need to change the preference
  to get this behavior). Not sure whether we can do something here.
Comment 1 Markus Keller CLA 2010-10-27 13:21:34 EDT 
Good points. I think we should offer a similar preference for Eclipse Application launch configurations. There, the preference would just be a location prefix (i.e. the constant string in LaunchArgumentsHelper#getDefaultWorkspaceLocation(String)).

Note that this is subtly different from what bug 127719 did for JUnit workspace locations: There, we always treat the base location as a folder into which we put the workspace. We should also change the behavior in the JUnit case and change the second radio in the prefs from "Create workspaces inside this folder" to something like "Append launch configuration name to this location".
Comment 2 Markus Keller CLA 2010-12-01 05:58:15 EST 
Created attachment 184237 [details]
Fix
Comment 3 Markus Keller CLA 2010-12-01 06:04:04 EST 
Curtis, would it be possible to get this in for M4? I can write the N&N entry (and include bug 127719, which has not been announced yet).
Comment 4 Markus Keller CLA 2010-12-01 06:55:34 EST 
Created attachment 184243 [details]
Fix 2

Sorry, the first patch was incomplete and it missed the link to the preference page.
Comment 5 Curtis Windatt CLA 2010-12-01 13:52:24 EST 
The preferences make sense, but the pref page is much too large (especially on linux).  The best option is probably to remove or reduce the groups as I can't see a good way to reduce the size of the new options.

Possible groups:
View - plug-in presentation and source options
Target - same as current
Export - same
Launching - update stale manifest and new workspace settings
Comment 6 Curtis Windatt CLA 2010-12-01 15:39:49 EST 
Created attachment 184300 [details]
Updated patch with pref page fix

Removed some of the grouping and cleaned up the page so that it isn't any longer than the JDT general page.
Comment 7 Curtis Windatt CLA 2010-12-01 15:40:55 EST 
Applied my updated patch to HEAD.  Markus, please take a quick look at the pref page before M4.
Comment 8 Markus Keller CLA 2010-12-01 16:10:28 EST 
Created attachment 184304 [details]
Improved labels

Thanks, the cleanup was a good idea. The only part I don't like is the
"Show plug-in objects in editors and dialogs using:" group, whose title doesn't fit "Show source plug-ins".

I think we could get away with "Plug-in presentation" or "Plug-in objects presentation" as title, see patch.
Comment 9 Curtis Windatt CLA 2010-12-01 16:26:02 EST 
Changes are excellent, committed your patch.
Comment 10 Curtis Windatt CLA 2010-12-08 15:36:18 EST 
Verified in I20101208-0800