Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328779

Summary:	[jdt-weaving] Enable JDT Weaving by default
Product:	[Tools] AJDT	Reporter:	Andrew Eisenberg <andrew.eisenberg>
Component:	Core	Assignee:	AJDT-inbox <AJDT-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	bugs.eclipse.org
Version:	2.1.1
Target Milestone:	2.1.2
Hardware:	Macintosh
OS:	All
Whiteboard:

Description Andrew Eisenberg

2010-10-26 19:00:49 EDT

It has been almost two years since we introduced JDT weaving into AJDT and we believe that most of the kinks have been worked out.  And thanks to the org.eclipse.equinox.weaving.cahcing plugin, the performance hit of having the weaving service turned on is negligible after the first startup.  Furthermore, the only problems we hear about regarding the weaving service are regarding problems with enabling it.  Finally, there are more features relying on JDT weaving now: STS and roo, Scala IDE, and potentially Groovy-Eclipse.

For all of these reasons, it is time to enable JDT weaving by default when AJDT is installed (and the ability to disable it through the UI is still important).

Comment 1 Andrew Eisenberg

2010-10-26 19:03:41 EDT

I just committed a first pass at this.  I was able to do some basic testing in my runtime workspace, but will have to wait until a build is avaiable before really being able to test.  

Here is what is entailed:

1. Needed to use the SimpleConfiguratorManipulator API to mark changes in the auto startup setting for the org.equinox.weaving.aspectj bundle.
2. Needed to add a p2.inf file to org.eclipse.equinox.weaving.aspectj bundle to change its auto-start setting to true on install.

Comment 2 Andrew Eisenberg

2010-11-15 01:26:30 EST

Now working in the snapshot version of AJDT.  JDT Weaving will not be enabled in an upgrade, only on a fresh install.

Comment 3 Andrew Eisenberg

2010-11-23 19:31:35 EST

Now working.