Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328726

Summary: [Compatibility] Cannot open views in 'Java Browsing' perspective
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact: Remy Suen <remy.suen>
Severity: major    
Priority: P3    
Version: 1.0   
Target Milestone: 4.1 M3   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
ModeledPageLayout patch v1 none

Description Remy Suen CLA 2010-10-26 10:44:02 EDT 
I20101025-1602

1. Window > Open Perspective > Java Browsing
2. Window > Show View > Ant
3. Nothing happens.
4. Window > Show View > Console
5. Nothing happens.

The only indication that something has actually happened is that whatever part you had active no longer has its parent folder coloured in blue which would imply that a different part has been activated.

Resizing the window does not help so this does not appear to be a layout problem.
Comment 1 Remy Suen CLA 2010-10-26 12:39:24 EDT 
There are two things wrong here.

First, ModeledPageLayout creates (3.x) placeholder stacks by relying on the 'visible' feature instead of the 'toBeRendered' feature.

Second, the EModelService's bringToTop(MUIElement) merely sets the element's 'toBeRendered' flag to 'true'. It should set the 'visible' flag to 'true' also.
Comment 2 Remy Suen CLA 2010-10-26 13:23:28 EDT 
(In reply to comment #1)
> Second, the EModelService's bringToTop(MUIElement) merely sets the element's
> 'toBeRendered' flag to 'true'. It should set the 'visible' flag to 'true' also.

<rcjsuen> emoffatt: Should EModelService's bringToTop method set 'visible' to true?
<emoffatt> no...if the stack is minimized then bringing one of its parts 'to top' shouldn't put it back in the presentation
<emoffatt> it's starting to appear as if the general rule is that 'visible' == false puts the control under whomever set it to false, the general code should *never* change it (at least I can't think of a case offhand where this makes sense)
<emoffatt> it's up to the 'hijacking' code to ensure that everything still works :)
Comment 3 Remy Suen CLA 2010-10-27 07:38:14 EDT 
Created attachment 181822 [details]
ModeledPageLayout patch v1
Comment 4 Remy Suen CLA 2010-10-27 09:35:01 EDT 
(In reply to comment #3)
> Created an attachment (id=181822) [details]
> ModeledPageLayout patch v1

Patch released to CVS HEAD.