Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328697

Summary:

Deadlock when starting Eclipse and waiting for all EJB-Validators finished

Product:

[WebTools] WTP Java EE Tools

Reporter:

Stefan Cordes <rsc>

Component:

jst.j2ee

Assignee:

Carl Anderson <ccc>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc, remy.suen, rsc

Version:

3.2

Flags:

cbridgha: review+

Target Milestone:

3.2.3

Hardware:

OS:

Windows XP

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=315286

Whiteboard:

Attachments:

Description	Flags
Thread Dump from VisualVM	none
Same deadlock fix as j2ee models	none
Fix LooseconfigPackageImpl, too	none

Description Stefan Cordes

2010-10-26 09:01:15 EDT

Build Identifier: 20100917-0705

Thread synchronization is brocken in commonarchive.

See Visual VM Thread dump waiting for 
org.eclipse.emf.ecore.plugin.RegistryReader$EPackageDescriptor.getEPackage(RegistryReader.java:274)
but never coming back because of thread deadlock.

Fix need to be analog to jst.j2ee
https://bugs.eclipse.org/bugs/show_bug.cgi?id=315286

Reproducible: Always

Steps to Reproduce:
1. Start an Eclipse with several EJB Projects
2. Sometimes Validators won't finish because they wait for each other.

Comment 1 Stefan Cordes

2010-10-26 09:02:30 EDT

Created attachment 181718 [details]
Thread Dump from VisualVM

Comment 2 Remy Suen

2010-10-26 09:09:53 EDT

Seems unrelated to Eclipse's generic IDE support.

Comment 3 Carl Anderson

2010-10-26 12:52:35 EDT

The commonarchive EMF model needs to access the legacy J2EE EMF models in the same way as bug 315286.

Comment 4 Carl Anderson

2010-12-01 14:46:26 EST

Created attachment 184295 [details]
Same deadlock fix as j2ee models

Comment 5 Carl Anderson

2010-12-01 14:48:22 EST

This fix uses the J2EEInit.initEMFModels() to properly initialize the j2ee EMF models in order, and uses the same lock during initializePackageContents() to prevent re-entrance there.

I have run the entire J2EE JUnit bucket against this fix.

Comment 6 Carl Anderson

2010-12-01 15:35:48 EST

Created attachment 184299 [details]
Fix LooseconfigPackageImpl, too

Comment 7 Chuck Bridgham

2010-12-01 17:06:10 EST

approved

Comment 8 Carl Anderson

2010-12-01 19:52:44 EST

Committed to R3_2_maintenance and HEAD for WTP 3.2.3 and WTP 3.3