Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328661

Summary:

[WPE] Too many "Drag and drop Web page content here" areas on design page

Product:

[WebTools] Java Server Faces

Reporter:

Ian Trimble <ian.trimble>

Component:

Assignee:

Ian Trimble <ian.trimble>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

carlin.rogers, david_williams, raghunathan.srinivasan

Version:

3.2.2

Flags:

david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: review+

Target Milestone:

3.2.3

Hardware:

OS:

Windows XP

URL:

ORACLE_P1

Whiteboard:

PMC_approved

Attachments:

Description	Flags
Suppresses display of the area if the element is considered to have only an end tag	none

Description Ian Trimble

2010-10-25 17:14:04 EDT

When using a jsp fragment as a header for taglib declarations, the main page design view shows two boxes for "Drag Web Page Content Here". Only one of the boxes can accept DnD tags.

WPE should only show one "Drag and drop Web page content here" area in this case (or even show none, if appropriate - but never more than one).

Sample pages:

------------------------------------------------------------
header.jsp:

<%@ page language="java" contentType="text/html; charset=ISO-8859-1" 
pageEncoding="ISO-8859-1"%>
@ <%@ taglib prefix="f"  uri="http://java.sun.com/jsf/core"%>
@ <%@ taglib prefix="h"  uri="http://java.sun.com/jsf/html"%>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" 
@ "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<title>Insert title here</title>
</head>
<body>

<h1>This is in header.jpg</h1>

------------------------------------------------------------
main.jsp:

<%@include file="header.jsp" %>

<f:view>
<h1>This is in main.jpg</h1>
</f:view>
</body>
</html>
------------------------------------------------------------

Comment 1 Ian Trimble

2010-10-25 17:15:55 EDT

The area with text will actually be shown once for every closing tag that has no corresponding opening tag in the same physical document. In this example, one is shown for "/body" and one is shown for "/html".

Comment 2 Ian Trimble

2010-10-25 17:18:27 EDT

Created attachment 181682 [details]
Suppresses display of the area if the element is considered to have only an end tag

Comment 3 Raghunathan Srinivasan

2011-01-19 13:57:06 EST

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
This bug affects end-user usability of the Web Page Editor.

* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
No workaround

* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
No Junit test. Manual testing.

* Give a brief technical overview. Who has reviewed this fix? 
See description.

* What is the risk associated with this fix? 
low

Comment 4 Ian Trimble

2011-01-21 11:53:14 EST

Checked in (3.2.3 and 3.3) on 1/20/2011.