Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328645

Summary: [TS Explorer] Moving attributes in TS Explorer doesn't work as expected
Product: [Technology] Tigerstripe Reporter: Navid Mehregani <nmehrega>
Component: UIAssignee: Project Inbox <tigerstripe.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: chrhartl
Version: unspecified   
Target Milestone: 0.5M0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
patch_328645.txt none

Description Navid Mehregani CLA 2010-10-25 14:25:18 EDT
Build Identifier: 

Moving attributes from one entity artifact to another in TS explorer doesn't work as expected.  Some of the attributes are duplicated.

Reproducible: Always

Steps to Reproduce:
1. Create a model project
2. Create a class diagram file in your project
3. Create two entity artifacts in class diagram: Entity0 & Entity1
4. Create four attributes under Entity0
5. Using TS Explorer, expand both artifacts
6. Select all attributes under Entity0 and move them to Entity1

Notice that the first attribute is moved as expected.  The rest of the attributes are copied across both artifacts.

The fix for this defect should also be tested with moving methods in TS Explorer.
Comment 1 Chris Hartley CLA 2010-10-25 17:42:22 EDT
Also check that both open and closed diagrams are correctly updated.
Comment 2 Chris Hartley CLA 2010-10-25 17:47:44 EDT
I think this is related to / similar to Bug 320140
Comment 3 Chris Hartley CLA 2010-10-25 18:45:16 EDT
When moving multiple attributes, TS seems to do a separate build after each attribute is moved - can we do all of the moves as a single transaction with one subsequent build ?
Comment 4 Navid Mehregani CLA 2010-10-25 18:52:01 EDT
(In reply to comment #3)
> When moving multiple attributes, TS seems to do a separate build after each
> attribute is moved - can we do all of the moves as a single transaction with
> one subsequent build ?

Doing batch builds can potentially be quite a bit of work and probably deserves another enhancement of its own :-)
Comment 5 Daniel Johnson CLA 2010-10-26 19:03:26 EDT
Created attachment 181790 [details]
patch_328645.txt

Can someone check if both closed/open diagrams are updated with this? It is working on my machine, but I have made some changes towards Bug 327698 . So if it doesn't work then it is related to that bug and not a problem with this bug.
Class Changed: ArtifactComponentTransferDropAdapter
Comment 6 Navid Mehregani CLA 2010-10-28 13:02:51 EDT
Thanks Dan! Yes, this does work for open/closed diagrams.
I see that your fix was similar to your changes for resolving delete operation of multiple attributes under an artifact in TS Explorer.