Bugzilla – Full Text Bug Listing
| Summary: | Constructor for org.eclipse.help.base.remote.RemoteIC has incorrect variable assignment | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Jim Perry <perryja> | ||||||
| Component: | User Assistance | Assignee: | Jim Perry <perryja> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ChrisAustin | ||||||
| Version: | 4.1 | ||||||||
| Target Milestone: | 3.7 M3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 181672 [details]
Patch with the unneeded variable assignment
Created attachment 181675 [details]
Patch with fix for this.protocol
Instead of removing the line, it should look like this
this.protocol = PROTOCOL_HTTP;
Instead of:
this.port = PROTOCOL_HTTP;
Patch committed to HEAD. |
Build Identifier: N20101023-2000 In the class org.eclipse.help.base.remote.RemoteIC, there is an incorrect assignment of this.port to the string HTTP_PROTOCOL. This must have been put there when we upgraded to support HTTPS protocol. public RemoteIC(boolean enabled, String name, String host, String path, String port){ this.enabled = enabled; this.name = name; this.host = host; this.path = path; this.port = port; this.port = PROTOCOL_HTTP; } The final line should be removed. Reproducible: Always Steps to Reproduce: 1. Open the class org.eclipse.help.base.remote.RemoteIC 2. Inspect the first constructor for the un-needed this.port variable assingment. 3.