Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328616

Summary: Clearly identify Agent Controller login dialog
Product: z_Archived Reporter: Mike Reid <mikereid>
Component: TPTPAssignee: Mike Reid <mikereid>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: normal    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard: adopters
Attachments:
Description Flags
Patch
none
Patch v2 none

Description Mike Reid CLA 2010-10-25 10:55:05 EDT 
Bug 327686 corrected a failure to attach to running agents in the profile on server case (when the AC is secured). The result of the fix is that the user is prompted to login to the secured Agent Controller when the server is started in profiling mode and the workbench attempts to attach to the profiling agents.

However the login dialog does not clearly identify itself as a prompt to login to an Agent Controller. In this case it is probably not a big deal since the user presumably knows the Agent Controller is secured and they are expecting to be prompt to start a profiling session.

However, other cases, particularly when downstream products may use the login API could potentially lead to confusion where the user doesn't know why they are being asked for a username/password.
Comment 1 Mike Reid CLA 2010-11-05 10:32:37 EDT 
Created attachment 182477 [details]
Patch

Attached patch that clarifies the purpose of the login dialog is to authenticate with the agent controller running on host X.
Comment 2 Mike Reid CLA 2010-11-08 15:42:05 EST 
Created attachment 182659 [details]
Patch v2

New patch fixes quote around NLS binding.
Comment 3 Mike Reid CLA 2010-11-08 15:42:45 EST 
Patch checked into HEAD.
Comment 4 Kathy Chan CLA 2011-02-11 13:46:32 EST 
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 5 Mike Reid CLA 2011-04-04 10:57:57 EDT 
Closing.