Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328459

Summary: Generate Result dialog allows you to edit Run Log
Product: [Technology] Tigerstripe Reporter: Duncan Keysell <dkeysell>
Component: UIAssignee: Daniel Johnson <danijoh2>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: chrhartl, nmehrega
Version: unspecified   
Target Milestone: 0.5M0   
Hardware: Macintosh   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
screenshot of editable text box on dialog
none
patch_328459.txt
none
Screenshot
none
patch_328459.txt none

Description Duncan Keysell CLA 2010-10-22 07:52:17 EDT
When you do a generate in TS it presents you with the "Generate Result" dialog at the end of the generate displaying the Run Log (see screenshot). Currently it is possible to edit the Run Log text box which should not be the case. Also the text box is given the focus which is also annoying.

The text box should be read-only and the OK button should get the focus.
Comment 1 Duncan Keysell CLA 2010-10-22 07:53:57 EDT
Created attachment 181490 [details]
screenshot of editable text box on dialog
Comment 2 Daniel Johnson CLA 2010-10-26 17:22:36 EDT
Created attachment 181787 [details]
patch_328459.txt

Patch to make generate results text box longer editable.
Class Changed: GenerateResultDialog
Comment 3 Navid Mehregani CLA 2010-10-27 19:27:41 EDT
Thanks! Reviewed and submitted.
Comment 4 Navid Mehregani CLA 2010-11-17 16:59:21 EST
Reopening defect, since the text displayed in the generation dialog should be selectable.  User should be able to select and copy it.  It should not be editable.  Also the text no longer seems to be scrollable, which isn't good (see attached screenshot).
Comment 5 Navid Mehregani CLA 2010-11-17 16:59:51 EST
Created attachment 183358 [details]
Screenshot
Comment 6 Daniel Johnson CLA 2010-11-17 17:39:47 EST
Created attachment 183360 [details]
patch_328459.txt

oops, marked it as isEnabled(false) instead of isEditable(false). Now can scroll and copy text correctly.
Comment 7 Navid Mehregani CLA 2010-11-17 20:58:26 EST
Looks good.  Thanks! submitted