Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328456

Summary:	Using XML/EJBJAR/WEBAPP discoverer from popup menu leads to wrong model opening
Product:	[Modeling] MoDisco	Reporter:	Fabien Giquel <fabien.giquel>
Component:	Technologies	Assignee:	Fabien Giquel <fabien.giquel>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	gdupe, hugo.bruneliere, modisco.web-inbox
Version:	0.9.0	Flags:	fabien.giquel: indigo+
Target Milestone:	0.9.0 M4
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Fabien Giquel

2010-10-22 07:37:28 EDT

It is a general pb with a category of discoverers which does not serialize the resulting models : 
- Generic XML Model Discoverer
- EjbJar XML Model Discoverer
- WebApp XML Discoverer

When called from the popup menu on a file, the discovery itself is ok but the model openening in modisco browser reinstantiate the model from the "XX.xml" file which leads to call another EMF Resource Factory -> the model finally opened does not conform to the mm asked.

This pb does not occurs with other discoverers which produces a .xmi result file.

This side effect is not visible in 0.8 since only 'Generic XML discoverer' was included.

Comment 1 Fabien Giquel

2010-10-22 07:41:40 EDT

This problem has to be resolved within the MoDisco Discovery Framework refactoring task which is currently in progress.

Comment 2 Fabien Giquel

2010-11-15 09:58:06 EST

a reminder : not sure of the reason why a wrong Resource Factory is used by the Modisco Browser : the code used to force the good factory in global Resource.FActory registry. It used to work.


Whatever the problem is, the good solution is to give the instanciated resource directly to the MoDisco browser -> MoDisco Discovery Framework
refactoring task.

Comment 3 Fabien Giquel

2010-12-14 06:13:42 EST

Completing last comment :

"the code used to force the good factory in global Resource.FActory registry. It used to work."

The problem comes now from MoDisco Model browser which evolves with some asynchronous model opening (to avoid UI freez i think) -> the workaround "force the good factory in global Resource.FActory registry" does not work anymore.

For instance : taking a "web.webapp25" file, and launching a "discover generic xml" results in opening a webapp25 model rather than a xml model.

Comment 4 Fabien Giquel

2010-12-14 08:24:50 EST

Fixed the three discvoerers (XML, JEE webapp and ejbjar discoverer) for sending directly the result Resource to the MoDisco browser (rev 3629).

Comment 5 Hugo Bruneliere

2011-01-11 05:06:25 EST

Bug fixed.