Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328443

Summary:

Location of Default button on ts-plugin.xml "Plugin Settings" tab confusing

Product:

[Technology] Tigerstripe

Reporter:

Duncan Keysell <dkeysell>

Component:

Assignee:

Project Inbox <tigerstripe.ui-inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

nmehrega

Version:

unspecified

Target Milestone:

0.5M0

Hardware:

Macintosh

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
screenshot of example entry of the "Plugins Settings" tab	none
patch_328443.txt	none
Generator Page	none
patch_328443.txt	none
patch_328443_fix.txt	none

Description Duncan Keysell

2010-10-22 05:09:54 EDT

I think the location of the Default button on the "Plugin Settings" tab of ts-plugin.xml. It is in the second column and looks like it just resets the default of the Enabled checkbox.

There are other issues with the layout of this section (see screenshot).

1. I think enabled checkbox should be this highest item.
2. Some of the labels end with ":" and some don't.
3. The tab should be called "Generator Settings" rather than "Plugin Settings"
4. The labels don't align.

Comment 1 Duncan Keysell

2010-10-22 05:12:56 EDT

Created attachment 181478 [details]
screenshot of example entry of the "Plugins Settings" tab

Comment 2 Navid Mehregani

2010-10-22 12:25:48 EDT

I agree.  I've been kind of ignoring this page :-) The changes you suggested makes sense.

Comment 3 Daniel Johnson

2010-10-26 18:24:46 EDT

Created attachment 181789 [details]
patch_328443.txt

Made suggested changes and renamed the "Enabled" checkbox to "generatorEnabled" and the "Default" button to "Reset Default Values". I am not convinced that the layout is the best, but it is mostly better.
Classes Changed:
OsgiPluggablePluginSection
PluggablePluginSection
PluginConfigurationPage
BooleanPropertyRenderer
StringPropertyRenderer
TablePropertyRenderer

Comment 4 Navid Mehregani

2010-10-27 19:56:19 EDT

Created attachment 181900 [details]
Generator Page

I think this page still requires some work (see attached snapshot for more details):
1) 'generatorEnabled' should be renamed to 'Enable Generator'
2) 'Reset Default Values' should be renamed to 'Restore Defaults' and should be moved to the bottom of the form section.  This follows the same convention as preference pages in Eclipse.
3) The column widths of a table properly should be resized to get rid of the empty space indicated in snapshot
4) Buttons for a table property should be properly aligned
5) 'Browse' button for 'Use Facet' should be renamed to 'Select'.  Browse button is typically used to select a file/directory.  'Select' is more appropriate and it's consistent with our other forms.

See attached file for more details.

Comment 5 Daniel Johnson

2010-10-28 14:54:31 EDT

Created attachment 181982 [details]
patch_328443.txt

Made Navids suggested changes as well.
Classes Changed:
OsgiPluggablePluginSection
PluggablePluginSection
PluginConfigurationPage
BooleanPropertyRenderer
StringPropertyRenderer
TablePropertyRenderer

Comment 6 Navid Mehregani

2010-10-28 15:50:47 EDT

Awesome!! Submitted your patch with a minor modification to also disable 'Add' button of Table property when generator is disabled.
Thanks!

Duncan, please reopen if this isn't to your liking.

Comment 7 Duncan Keysell

2010-11-01 13:14:22 EDT

Looks good. Thanks.

Comment 8 Daniel Johnson

2010-11-03 13:26:35 EDT

Created attachment 182311 [details]
patch_328443_fix.txt

I introduced a bug that made the generator settings page render incorrectly when osgi was not being used. This patch fixes that issue. Also renamed "Select" button to "Select..." as it opens a dialog. This fix should be applied after patch_328443
Class changed: PluggablePluginSection

Navid can you please commit?

Comment 9 Navid Mehregani

2010-11-03 14:29:28 EDT

Reviewed and submitted.  Thanks!