Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328422

Summary: Need IKeyBindingService and INestableKeyBindingService
Product: [RT] RAP Reporter: Elias Volanakis <elias>
Component: WorkbenchAssignee: Project Inbox <rap-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: rsternberg
Version: 1.4   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch none

Description Elias Volanakis CLA 2010-10-21 20:39:56 EDT
See patch. Code was already in RAP but commented out.

We need these for single sourcing. They are deprecated _but_ in RCP they are part of a method signature in IWorkbenchPartSite, which we implement.
Comment 1 Elias Volanakis CLA 2010-10-21 20:40:40 EDT
Created attachment 181458 [details]
patch
Comment 2 Elias Volanakis CLA 2010-10-26 16:48:07 EDT
Hi Ivan/RAP-team, 

could you review and commit the attached patch? I need it for my project.

Thanks,
Elias.
Comment 3 Ralf Sternberg CLA 2010-10-28 19:06:39 EDT
(In reply to comment #2)
> could you review and commit the attached patch? I need it for my project.

Usually, we do not incur deprecated code from the platform. The method you refer to on IWorkbenchPartSite is also deprecated. Is there no other way to single-source this?
Comment 4 Elias Volanakis CLA 2010-11-03 12:40:51 EDT
This one I have to investigate some more.
Comment 5 Ralf Sternberg CLA 2010-11-29 04:10:58 EST
Closing this bug for now. Elias, if you're still interested, please reopen.