Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328419

Summary: [General] Papyrus should provide handlers for the Edit menu
Product: [Modeling] Papyrus Reporter: Yann Tanguy <yann.tanguy>
Component: CoreAssignee: Vincent Lorenzo <vincent.lorenzo>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: vincent.lorenzo: documentation+
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Yann Tanguy CLA 2010-10-21 18:30:03 EDT
When the active editor is Papyrus, handlers for the eclipse Edit menu should be provided (e.g. org.eclipse.ui.edit.delete).
Comment 1 Vincent Lorenzo CLA 2010-11-22 08:44:43 EST
The class org.eclipse.gmf.runtime.diagram.ui.parts.DiagramEditor provides some keys binding, without using the extension point org.eclipse.ui.keybindings.
In order to ensure a correct keybinding for the Delete Action in the Diagram, we need to remove the following keybinding in the inherited classes : 
keyHandler.put(KeyStroke.getPressed(SWT.DEL, 127, 0), getActionRegistry().getAction(ActionFactory.DELETE.getId()));

This binding is removed in r3286.
Comment 2 Vincent Lorenzo CLA 2010-11-23 03:18:16 EST
In r3291
	done for the delete action : now the 3 Delete Action (in Model Explorer, Menu Edit and Diagram) are the same. For the Diagram, a specific keybinding is defined in the plugin.xml of the common (DEL for Hide and CTRL+DEL for Delete).

	A class StateActionSourceProvider is added to these plugins. The changes of the variable provided by these classes allow to refresh the state of the action in the Menu Edit.
Comment 3 Yann Tanguy CLA 2010-11-26 04:48:46 EST
In r3372:
Comment added in plugin.xml.
Comment 4 Vincent Lorenzo CLA 2011-01-05 09:19:50 EST
In R3606 : minor change in org.eclipse.papyrus.modelexplorer.provider.ActionStateSourceProvider : 
an equals() replaced by an Instanceof!
Comment 5 Vincent Lorenzo CLA 2011-01-07 03:26:12 EST
Merged with trunk in R3633
Comment 6 Vincent Lorenzo CLA 2011-07-11 04:47:51 EDT
This bug can be marked as closed