Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328364

Summary:

"Argument cannot be null" popup when editing a jsp which includes a tld with a not existing small-icon

Product:

[WebTools] WTP Source Editing

Reporter:

Benjamin <atha900>

Component:

jst.jsp

Assignee:

Nick Sandonato <nsand.dev>

Status:

RESOLVED FIXED

QA Contact:

Nick Sandonato <nsand.dev>

Severity:

normal

Priority:

CC:

thatnitind

Version:

3.2.2

Flags:

thatnitind: review+

Target Milestone:

3.2.3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Stack trace	none
A jsp to reproduce the bug	none
A tlb to reproduce the bug	none
patch	none

Description Benjamin

2010-10-21 10:58:57 EDT

Build Identifier: 20100917-0705

If a small icon is defined in a tld, and that tld is referenced in a jsp, the jsp editor constantly pops up a very annoying error message:
"Problem Occured" - An error has occured. ...


Reproducible: Always

Steps to Reproduce:
1.Take bug attachments (tlib.jsp and tlib.tld) and copy them into the WebContent folder of any Dynamic Web Project
2.Open the tlib.jsp
3.Start editing the jsp (or just click on some part of the jsp with the pointer): the error message will constantly pops up

Comment 1 Benjamin

2010-10-21 11:00:21 EDT

Created attachment 181404 [details]
Stack trace

the stack trace (a FileNotFound that causes a IllegalArgumentException)

Comment 2 Benjamin

2010-10-21 11:00:59 EDT

Created attachment 181405 [details]
A jsp to reproduce the bug

Comment 3 Benjamin

2010-10-21 11:01:19 EDT

Created attachment 181406 [details]
A tlb to reproduce the bug

Comment 4 Nick Sandonato

2010-10-21 11:12:54 EDT

Thank you for the steps to reproduce and some test files.

Comment 5 Nick Sandonato

2010-10-22 13:31:52 EDT

Created attachment 181525 [details]
patch

We should be checking that the inputstream returned from the Jar Utility is not null. Also, do not log FileNotFoundExceptions.

Comment 6 Nick Sandonato

2010-10-22 14:27:07 EDT

Released to 3_2_Maintenance and HEAD. Thanks for reviewing, Nitin.