Bugzilla – Full Text Bug Listing
| Summary: | RuntimePreferencePage does not update if new runtimes are added | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | Rob Stryker <stryker> | ||||||||
| Component: | wst.server | Assignee: | Elson Yuen <eyuen7> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Angel Vera <arvera> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | 3.2 | ||||||||||
| Target Milestone: | 3.2.4 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| See Also: | https://git.eclipse.org/r/109027 | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Rob Stryker
Created attachment 181356 [details]
Adds a runtime lifecycle listener to the page
Patch above, fairly simple.
I'd like to see this in 3.2.3 release if its possible. Created attachment 181357 [details]
Adds lifecycle listener, display.async executes hte update
Previously forgot that the events might come in on other threads.
I am working on the plan for 3.2.3 right now. It sounds that you did some testing already. Is it possible to identify in bullets the scenarios that you tested? that will give me more confidence on the patch and save time on me reviewing the code. 1) create new preference page with buttons which can add / remove runtimes 2) add a runtime on new page, switch to official pref page, observe runtime was added 3) remove a runtime on new page, switch to official pref page, observe runtime was removed 4) rename a runtime, save it, switch to official pref page, observe runtime was updated Even if you did a code-review here, it's a pretty small patch and should not take long. I basically made the RuntimeComposite field a member field, added the page as a lifecycle listener during creation, removed it during dispose(), and respond to lifecycle events by refreshing the composite / viewer. Any reason why you couldn't squeeze in fixing a bug with an easy to understand pre-made and contributed patch which sat on the bug for three months? Rob, It was a matter of priorities and impact to the product. Created attachment 190921 [details]
v1.0
Updated the patch with adding missing method on the previous patch.
Changes released to 32M. Tested the scenario on a runtime has been added when the Runtime Enviornment preference page is already up and running. The newly added runtime gets refreshed on the table properly. Changes released to 33M Elson, I am reopening this bug to ensure that we do a proper check that the bug is fixed in 324. I know this one had some problems integrating it with our builds because it was during smoke test time. Can you please double check that your changes made it into 324, if not then please re-release. It might also worth checking the 3.3 builds I only marked this defect has been resolved after resolving the build integration issue. Therefore, the changes are released on both 32M and 33M. New Gerrit change created: https://git.eclipse.org/r/109027 |