Bug 328300

Comment 1 Steffen Pingel 2010-10-20 18:28:55 EDT

Thanks for the bug report. Do you have a sample project that you could attach and steps to reproduce the problem?

Comment 2 Andrey Kourskov 2010-10-20 19:34:33 EDT

(In reply to comment #1)
> Thanks for the bug report. Do you have a sample project that you could attach
> and steps to reproduce the problem?

Steps to reproduce
1) File -> New -> C++ Project
2) Project name = HelloWorld
3) Project type = Executable HelloWorld C++ Project
4) Finish
5) TaskList -> NewTask (Local)
6) Save task
6) Activate task
7) Open HelloWorld.cpp in created C++ project
8) Open context of the created task or open Project Explorer(Focus on active task should be enable)

Comment 3 Andrey Kourskov 2011-01-27 19:18:08 EST

Is it possible to fix this bug in Helios SR2?

Comment 4 Steffen Pingel 2011-01-27 23:57:01 EST

Thanks for the detailed steps. I have put it on for 3.5 so that it doesn't get lost. We'll try to look at it for 3.4.3 (SR2) but I can't promise anything.

Comment 5 Sam Davis 2011-01-28 20:08:10 EST

I am able to reproduce this. Note that includes can be added to the context in SR1 but could not previously. This bug may be a side effect of that.

Comment 6 Sam Davis 2011-01-28 21:27:09 EST

This may be a CDT bug. The problem seems to be that some of elements have the same handle identifier (for me it's "=MinGW"). For me these are the elements below:

C:/MinGW/lib/gcc/mingw32/4.5.2/include/c++/backward
C:/MinGW/lib/gcc/mingw32/4.5.2/include/c++/mingw32/bits
C:/MinGW/include/ddk
C:/MinGW/lib/gcc/mingw32/4.5.2/include/c++

This causes canFilter to return false. If we could detect which elements didn't have a proper handle identifier we could just ignore them. That would fix this bug but might prevent includes from showing up in the context when they should.

Comment 7 Sam Davis 2011-01-28 21:27:12 EST

Created attachment 187896 [details]
mylyn/context/zip

Comment 8 Sam Davis 2011-02-04 13:56:39 EST

I have filed a bug against CDT:

336387: IncludeReferences have the same handle identifier as the project
https://bugs.eclipse.org/bugs/show_bug.cgi?id=336387

Comment 9 Shawn Minto 2011-02-04 14:06:26 EST

Created attachment 188351 [details]
Patch

Here is a patch that should fix this problem.  The IncludeReference's that are now shown under the project have the same handle identifier as the project.  This means that once the project is a part of the context, all of these IncludeReferences are shown in focused mode.  The fix that I did is to ensure that if the element is not a project that its handle is not the same as the project.  This means that if there is another breakage like this in CDT or a fix is implemented that the focused mode will work correctly.

The CDT bug that was created from this investigation:

336387: IncludeReferences have the same handle identifier as the project
https://bugs.eclipse.org/bugs/show_bug.cgi?id=336387

Comment 10 Shawn Minto 2011-02-04 14:06:28 EST

Created attachment 188352 [details]
mylyn/context/zip

Comment 11 Shawn Minto 2011-02-04 14:09:21 EST

Note that we need to setup tests to make sure that we are happy with this.

Comment 12 Steffen Pingel 2011-02-04 14:59:23 EST

Created attachment 188361 [details]
patch for head

Comment 13 Steffen Pingel 2011-02-04 18:35:17 EST

Thanks for fixing this Shawn! I have applied the patch to the e_3_6_m_3_4_x branch and head. A 3.4.3.v20110204-0608 build is now available from http://download.eclipse.org/tools/mylyn/update/maintenance.

This fix will be in next week's Helios SR2 RC3 build.