Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328294

Summary: In properties for Connection Profile, when user unchecks the Save password option, the password is still saved for the duration of the session
Product: [Tools] Data Tools Reporter: Salvador Ledezma <ledezma>
Component: ConnectivityAssignee: Brian Payton <bpayton>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bpayton, ledezma, sholars
Version: 1.8.2Flags: bfitzpat: review+
Target Milestone: 1.8.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed patch to fix the bug. none

Description Salvador Ledezma CLA 2010-10-20 16:27:21 EDT 
Build Identifier: Version: 3.6.1.r361_v20100827 Build id: M20100909-0800

In the Data Source Explorer, there is a properties dialog for connection profile properties, including host name, database, user id, and password.  The user is given a choice for the password field on whether it should be saved or not.

The current behavior is that when the user enters the password and chooses not to save, it is still kept around for the duration of the workspace session.

In particular, for example, let's say the connection is made, some tasks are completed, and the user disconnects.  If the properties dialog is brought up again, the password is still there in the field though the save option has not been selected.

If the workspace is restarted, then the properties dialog is shown, only then the password field is empty.

Reproducible: Always

Steps to Reproduce:
Steps to Reproduce:
1. Open a new workspace
2. Create a new connection.  In the properties of the connection uncheck the "save password" checkbox
3. Connect
4. Right-click on the new connection and select properties

Actual Results:
Password is saved in the text box.  Only when Eclipse restarts is the password blank

Expected Results:
Password field should be empty and password should not be saved, even during the same session
Comment 1 Salvador Ledezma CLA 2010-10-20 16:30:32 EDT 
Created attachment 181338 [details]
Proposed patch to fix the bug.

If the "Save password" option is unchecked, it is now honored within the workspace session and does not require a workspace restart to clear out the field.
Comment 2 Salvador Ledezma CLA 2010-10-20 16:33:25 EDT 
Please apply this patch to DTP 1.9 too.
Comment 3 Brian Fitzpatrick CLA 2010-10-20 18:01:44 EDT 
Looks good to me to go ahead and deliver to both 1.8.2 and 1.9.
Comment 4 Brian Payton CLA 2010-10-21 00:53:49 EDT 
Checked in patch for DTP 1.8.2, tagged to v201010211245
Comment 5 Brian Payton CLA 2010-10-21 02:04:52 EDT 
Checked in patch to DTP 1.9, tagged to v201010211400
Comment 6 Brian Payton CLA 2010-10-21 02:18:12 EDT 
Resolving as fixed