Bugzilla – Full Text Bug Listing
| Summary: | Support rendering decorator positioning for connection text decorator | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Graphiti | Reporter: | Shenxue Zhou <shenxue.zhou> | ||||||
| Component: | Core | Assignee: | Project Inbox <graphiti-inbox> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | matthias.gorning, michael.wenz | ||||||
| Version: | 0.7.0 | Flags: | michael.wenz:
juno+
|
||||||
| Target Milestone: | 0.9.0 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | Juno M4 theme_round_offs | ||||||||
| Attachments: |
|
||||||||
|
Description
Shenxue Zhou
Would like to target for Juno Just as clarification: What's still missing is a possibility to place the decorator in front of text decorator outside of the actual text GA. Flagged as enhancement Created attachment 207470 [details]
Proposed solution
In order to be able to draw outside of the bounds of the decorated figure, I've added the decorating figure to the original figure's parent.
It has some implications on removal, since now the decorating figure isn't contained by the decorating one. Now the decorating figures are explicitly removed in the deactivate method of the decorated figure.
Also, the real position of the decorated figure is obtained from the constraint in its parent layout instead of its declared bounds, since they are yet not updated.
This allows the decorator to lie outside its owner bounds, not only for text connections, but for any PE.
Created attachment 207474 [details]
Proposed solution, second edition
When adding the decorating figure to the decorated figure's parent, add it just after the decorated one, in order to properly support the z-index.
@Felix: Thanks for this contribution. I've committed this patch to the master branch. commit 91f28cea41d287aaa3848e057769a1518b589a3c Author: mgorning <matthias.gorning@sap.com> 2011-12-09 10:32:25 Committer: mgorning <matthias.gorning@sap.com> 2011-12-09 10:32:25 Parent: b0bc6abbcf1a95637cc1e2ee55a468d383467466 (Bug 328279 - Support rendering decorator positioning for connection text decorator) Branches: master Bookkeeping: Set target release Part of Graphiti 0.9.0 (Eclipse Juno) |