Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328276

Summary: Attribute value proposals cannot filter qualified values
Product: [WebTools] WTP Source Editing Reporter: Nick Sandonato <nsand.dev>
Component: wst.htmlAssignee: Nick Sandonato <nsand.dev>
Status: RESOLVED FIXED QA Contact: Nick Sandonato <nsand.dev>
Severity: normal    
Priority: P3 CC: thatnitind
Version: 3.2.3Flags: thatnitind: review+
Target Milestone: 3.2.3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
updated patch none

Description Nick Sandonato CLA 2010-10-20 14:01:15 EDT 
Often times, attribute values may contain some kind of qualified value like "foo.bar.Button". When you have several options like "foo.bar.Button" "foo.bar.Input", "foo.bar.Anchor" and so on. That's a lot of typing if your qualified names are long, when it might be easier to just filter on "Button".
Comment 1 Nick Sandonato CLA 2010-10-20 14:08:16 EDT 
Created attachment 181322 [details]
patch
Comment 2 Nitin Dahyabhai CLA 2010-10-20 17:57:31 EDT 
Looks good, but fAlternateMatch.substring(0, length) could be a problem if the word length is already greater than the alternate match's length.
Comment 3 Nick Sandonato CLA 2010-10-21 10:31:31 EDT 
Created attachment 181398 [details]
updated patch

Ah, nice catch. I also fixed this in the unlikely scenario where if the display string is null, and an alternate match is provided, we'll use it.
Comment 4 Nick Sandonato CLA 2010-12-14 15:41:27 EST 
Thanks for the review.