Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328232

Summary:	EditHelper getDestroyDependentCommand ignored when a specific IClientContext is required
Product:	[Modeling] GMF-Runtime	Reporter:	Yann Tanguy <yann.tanguy>
Component:	General	Assignee:	Project Inbox <gmf-runtime-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	328506

Description Yann Tanguy

2010-10-20 07:07:40 EDT

Currently using the ExtensibleType framework in a way that requires IClientContext to be provided explicitly, it seems that the getDestroyDependentCommand from EditHelper never gets called.

These EditHelper directly inherit from AbstractEditHelper. This may be related to the fact the ElementType is sometimes retrieved (see: getDestroyElementWithDependentsCommand or getDestroyElementCommand) from the registry without providing the client context.
e.g.
protected ICommand getDestroyElementCommand(DestroyElementRequest req) {
		...
			if (parentMap != null) {
    			parentType = (IElementType) parentMap
    				.get(RequestCacheEntries.Element_Type);
			} else {
			    parentType = ElementTypeRegistry.getInstance().getElementType(parent); 
		...