Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328221

Summary: Several error messages are confusing/useless
Product: z_Archived Reporter: Aaron Digulla <digulla>
Component: BIRTAssignee: Jianchao Li <jianchao.li>
Status: VERIFIED FIXED QA Contact: Xiaoying Gu <bluesoldier>
Severity: normal    
Priority: P3 CC: bluesoldier, jianchao.li, wenfeng.fwd
Version: unspecified   
Target Milestone: 3.7.0 RC1   
Hardware: All   
OS: All   
Whiteboard: Obsolete
Attachments:
Description Flags
Patch for org.eclipse.birt.data
none
Patch for org.eclipse.birt.report.data.oda.jdbc
none
Patch for org.eclipse.birt.report.engine
none
Test case for broken error messages none

Description Aaron Digulla CLA 2010-10-20 05:12:48 EDT 
Build Identifier: BIRT 2.5.2

I've fixed a couple of error messages in BIRT 2.5.2 which are confusing/useless. See the attached patches.

I'm aware that this patch is for an old version of BIRT but maybe they are still useful for someone stuck with BIRT 2.5.2. I didn't check whether the errors are still there in 2.6; feel free to have a look.

Bugs fixed:

1. When a pre-compiled method is run and an error happens, the source of the method is included (so you get more than "There was an error in __bm_OPEN").

2. Instead of "data.engine.BadFetchScriptReturnType", you get a real error message with the method name and the value returned.

3. If logging is enabled for jdbc.Statement, the log would fill with thousands of stack traces warning that "setSpecification is not supported."

Feel free to use the patches in any legal way.

Reproducible: Always
Comment 1 Aaron Digulla CLA 2010-10-20 05:14:00 EDT 
Created attachment 181263 [details]
Patch for org.eclipse.birt.data

Feel free to use this patch in any legal way.
Comment 2 Aaron Digulla CLA 2010-10-20 05:14:37 EDT 
Created attachment 181264 [details]
Patch for org.eclipse.birt.report.data.oda.jdbc

Feel free to use this patch in any legal way.
Comment 3 Aaron Digulla CLA 2010-10-20 05:15:50 EDT 
Created attachment 181265 [details]
Patch for org.eclipse.birt.report.engine

Feel free to use this patch in any legal way.
Comment 4 Aaron Digulla CLA 2010-11-09 05:24:40 EST 
Update for BIRT 2.6.1: The first issue is fixed (instead of a strange name, I see the code) but the other two are still there.
Comment 5 Aaron Digulla CLA 2010-11-09 06:25:07 EST 
Created attachment 182697 [details]
Test case for broken error messages

This report shows the broken error messages in 2.5.2 and 2.6.1.
Comment 6 Aaron Digulla CLA 2010-11-09 10:00:53 EST 
I have now applied my patches to 2.6.1. The line numbers changed a bit but otherwise, the data and engine patches are the same as for 2.5.2.
Comment 7 Aaron Digulla CLA 2011-03-15 11:16:00 EDT 
BIRT 2.6.2 contains most of my patch. The patch for org.eclipse.birt.data is no longer necessary.

The JDBC patch is also obsolete.

Only MessageConstants.SCRIPT_EVALUATION_ERROR still takes two arguments, so part of the patch for the report engine is still necessary.
Comment 8 Jianchao Li CLA 2011-05-17 01:48:50 EDT 
Apply the changes to the classes according to the patch in head and 2.6.1 branch.
Comment 9 Xiaoying Gu CLA 2011-05-22 22:33:21 EDT 
Verified in 3.7RC1.