Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328220

Summary:	use PDE build model API
Product:	[Modeling] MoDisco	Reporter:	Nicolas Bros <nicolas.bros>
Component:	Infrastructure	Assignee:	Gabriel BARBIER <barbier.gabriel>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	barbier.gabriel, gdupe, hugo.bruneliere, modisco.web-inbox
Version:	0.9.0	Flags:	nicolas.bros: indigo+
Target Milestone:	0.9.0 M5
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Nicolas Bros

2010-10-20 05:10:41 EDT

org.eclipse.gmt.modisco.infra.common.core.internal.utils.BuildPropertiesUtils#getBuildModel uses internal PDE methods to access the IBuildModel (to view and edit the contents of a build.properties file).

This was done this way, because IPluginModelBase#getBuildModel used to always return null. I created a bug for this API in PDE:
Bug 308623 - IPluginModelBase.getBuildModel() always returns null

Since Eclipse 3.7M2, calling getBuildModel() on IPluginModelBase objects will now return a handle to PDE's build model for that plug-in. 

So, the calls to internal methods should be replaced by this new API.

Comment 1 Gabriel BARBIER

2011-01-03 08:17:56 EST

Available in revision 3680

Comment 2 Nicolas Bros

2011-01-07 04:30:21 EST

In fact my first comment was wrong; getBuildModel() still returns null and is now deprecated. PluginRegistry#createBuildModel should be used instead.

Fixed in revision 3688.

Comment 3 Hugo Bruneliere

2011-01-11 05:04:19 EST

Bug fixed.