Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328207

Summary:	Use standard refresh icon in Search View
Product:	[Eclipse Project] Platform	Reporter:	Deepak Azad <deepakazad>
Component:	Search	Assignee:	Dani Megert <daniel_megert>
Status:	RESOLVED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	daniel_megert
Version:	3.7
Target Milestone:	3.7 M3
Hardware:	All
OS:	All
Whiteboard:

Description Deepak Azad

2010-10-20 02:34:06 EDT

Both icons have a small decorator on the top left indicating the action but the main icon is the same Search icon. I always have to look really closely to click the right button...

These icons should be same as the ones in Call Hierarchy view. (The same history button icon is also used in Type Hierarchy view)

Comment 1 Dani Megert

2010-10-20 02:42:19 EDT

> These icons should be same as the ones in Call Hierarchy view. 
Nope.
>(The same history button icon is also used in Type Hierarchy view)
This icon is JDT specific (the green dot for Java members).

==> we should use the standard refresh icon (the one with the two arrows).

Comment 2 Deepak Azad

2010-10-20 02:54:10 EDT

(In reply to comment #1)
> > These icons should be same as the ones in Call Hierarchy view. 
> Nope.
> >(The same history button icon is also used in Type Hierarchy view)
> This icon is JDT specific (the green dot for Java members).
ok.. is there a standard History icon ? If not maybe we should make the JDT specific one to be standard ? 

I dont really like the Search icon in the History button, but if we follow this paradigm on putting the view icon in the history button we should do the same in Call Hierarchy and Type Hierarchy views. Currently the icons are just inconsistent...

Comment 3 Dani Megert

2010-10-20 03:02:42 EDT

(In reply to comment #2)
> (In reply to comment #1)
> > > These icons should be same as the ones in Call Hierarchy view. 
> > Nope.
> > >(The same history button icon is also used in Type Hierarchy view)
> > This icon is JDT specific (the green dot for Java members).
> ok.. is there a standard History icon ? If not maybe we should make the JDT
> specific one to be standard ? 
No. As said, the green dots refer to the public method icon.

> I dont really like the Search icon in the History button, but if we follow 
> this paradigm on putting the view icon in the history button we should do the 
> same in Call Hierarchy and Type Hierarchy views. Currently the icons are just
> inconsistent...
The Team History icon also looks similar to the Search one and I agree with your inconsistency argument. However after years people got used to those icons and I see no point in changing well known icons at this point.

Comment 4 Dani Megert

2010-10-20 05:43:47 EDT

Fixed in HEAD.
Available in builds >= N20101020-2000.