Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328200

Summary: ServerUIPlugin shows server view when the view is not open
Product: [WebTools] WTP ServerTools Reporter: Jason Duan <jasonxd>
Component: wst.serverAssignee: Elson Yuen <eyuen7>
Status: RESOLVED FIXED QA Contact: David Williams <david_williams>
Severity: normal    
Priority: P3 CC: arvera, ccc, eyuen7
Version: 3.0.5Flags: arvera: review+
Target Milestone: 3.0.5 P   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 328981    
Attachments:
Description Flags
v1.0 none

Description Jason Duan CLA 2010-10-19 22:38:52 EDT 
Build Identifier: 3.0.5

In the ServerUIPlugin class, the protected static void showServersView(final boolean bringToFront) method shows the server view when the active page doesn't have the view. 

Reproducible: Always

Steps to Reproduce:
My ref number: 54818
Comment 1 Elson Yuen CLA 2010-10-20 14:48:01 EDT 
Typically, a view should not open itself.  The server preference setting should only bring the view to the front if the view has already been opened.
Comment 2 Elson Yuen CLA 2010-10-20 14:51:19 EDT 
Created attachment 181330 [details]
v1.0

This patch will make the server view to not open by itself. The view will still be brought to the front as needed if the view has already been opened depending on the preference settings.

Testing has been done on the case where the view has already been opened to make sure it brings to the front.  If the view is not opened, then the view will not show by itself.
Comment 3 Elson Yuen CLA 2010-10-28 17:55:04 EDT 
Angel has reviewed this patch already but he just went for vacation.  He'll mark the patch as reviewed when he comes back next Monday.
Comment 4 Carl Anderson CLA 2010-11-03 12:22:10 EDT 
Committed to R3_0_5_patches