Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328197

Summary: improve query page description if page does not have a refresh button
Product: z_Archived Reporter: Benjamin Muskalla <b.muskalla>
Component: MylynAssignee: Steffen Pingel <steffen.pingel>
Status: RESOLVED FIXED QA Contact:
Severity: trivial    
Priority: P3 CC: thomas.ehrnhoefer
Version: unspecified   
Target Milestone: 3.5   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
mylyn/context/zip none

Description Benjamin Muskalla CLA 2010-10-19 21:55:39 EDT
AbstractRepositoryQueryPage sets "If attributes are blank or stale press the Update button." as description for the page without any condition. Doesn't make sense under the following conditions:
- setNeedsRepositoryConfiguration(true)
- hasRepositoryConfiguration returns true

In this case, the message is misleading as the update button is not visible.
Comment 1 Steffen Pingel CLA 2010-10-19 23:40:44 EDT
Good point. Can you provide a patch to fix it?
Comment 2 Steffen Pingel CLA 2010-10-27 05:23:04 EDT
I have changed the description to "Create a query." if setNeedsRepositoryConfiguration(false) is specified. I believe the message makes sense otherwise as the configuration may have changed in the repository since the last update.
Comment 3 Steffen Pingel CLA 2010-10-27 05:23:07 EDT
Created attachment 181812 [details]
mylyn/context/zip