Bugzilla – Full Text Bug Listing
| Summary: | UseScanParser ignores result of visit methods | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Curtis Windatt <curtis.windatt.public> | ||||||
| Component: | API Tools | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ankur_sharma, darin.eclipse, Michael_Rennie | ||||||
| Version: | 3.7 | Keywords: | performance | ||||||
| Target Milestone: | 3.7 M4 | Flags: | Michael_Rennie:
review+
|
||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 322571 | ||||||||
| Attachments: |
|
||||||||
Assigning to myself for now. The patch is critical to making my visitor for bug 322571 work, but the performance issues are not major. The performance may be more important for Ankur's work on IDE integration. The critical fix was applied as part of bug 322571. We should still pursue the second part of this report as the performance gains will be significant for large use scans. Created attachment 183393 [details]
Fix to respect visit method results
Applied the fix to HEAD. Mike, please verify. looks good |
Created attachment 181228 [details] Fix to avoid calling endvisit methods The UseScanParser does a depth first search through a use scan xml folder and calls a UseScanVisitor to perform actions on it. Several of the visit methods (component, referencing component, member) allow boolean return values to specify whether children should be visited. If false is returned, no visit methods of the children should be called. This works. If false is returned, no end visit methods of the children should be called. This fails currently. I have a fix attached for this. If false is returned, the children should be skipped entirely. this fails currently. We parse every file fully even if we don't need to. Fixing this would improve performance for visitors that only care about certain components.