| Summary: | infinite loop when opening file from an UNC path | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Target Management | Reporter: | Krzysztof Kosmatka <krzysztof.kosmatka+eclipse> | ||||
| Component: | RSE | Assignee: | David McKnight <dmcknigh> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
| Severity: | major | ||||||
| Priority: | P2 | CC: | dmcknigh | ||||
| Version: | 3.1.2 | ||||||
| Target Milestone: | 3.3 M3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Thanks for the report, and clear analysis! I would claim that product hangup is a major issue, so I'm pushing it up to a P2. Who could look at a fix? I'm afraid that UNC paths have not received much testing in RSE and more issues may be detected. Note that the Eclipse Platform team has prepared a Wiki page with recommendations for dealing with UNC paths: http://wiki.eclipse.org/Eclipse/UNC_Paths I'll take a look. Created attachment 181200 [details]
patch to consider \\ on local windows as a root
Could you please try your scenario out with this patch? Also does a fix here need to be backported?
I've committed the change to the HEAD stream. Please let me know if you need a backport for the RSE 3.2.2 release. Thanks, your patch fixes the problem. I dont't need a backport. |
When I try to open file from network share, eclipse jupms into infinite loop. Steps to reproduce: 1) In "Remote Systems" view add new "Local" connection 2) Right click on "Local Files" node, select "New->Filter..." 3) In "Folder" field type the name of network share (\\some\network\share) 4) Click Next, and then Finish Result: Selected network share shows up as a filter in Remote Systems view. I can browse folders, see files names, but when I try to open any file from this network share, it fails. In Progress view I see "Download". I found out, that program jupms into infinite loop in method org.eclipse.rse.subsystems.files.core.subsystems.RemoteFile.getEncoding(), because method getParentPathFor("\") returns "\". I hope I clearly explained, what the problem is.