Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328023

Summary:	GenModel editor crashes with NPE when referencing OCL metamodel
Product:	[Modeling] EMF	Reporter:	Michael Zeising <michael>
Component:	Core	Assignee:	Ed Merks <Ed.Merks>
Status:	CLOSED FIXED	QA Contact:
Severity:	critical
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Michael Zeising

2010-10-18 05:34:58 EDT

Build Identifier: 20100917-0705

As soon as I reference the OCL metamodel by adding

usedGenPackages="platform:/plugin/org.eclipse.emf.ecore/model/Ecore.genmodel#//ecore platform:/plugin/org.eclipse.ocl/model/OCL.genmodel#//ocl platform:/plugin/org.eclipse.ocl.ecore/model/OCLEcore.genmodel#//ocl"

to my genmodel file, the editor crashes with the following stack trace:

java.lang.NullPointerException
	at org.eclipse.emf.codegen.ecore.genmodel.impl.GenBaseImpl.findGenPackageHelper(GenBaseImpl.java:870)
	at org.eclipse.emf.codegen.ecore.genmodel.impl.GenModelImpl.findGenPackage(GenModelImpl.java:1839)
	at org.eclipse.emf.codegen.ecore.genmodel.impl.GenModelImpl.computeMissingUsedGenPackages(GenModelImpl.java:8651)
	at org.eclipse.emf.codegen.ecore.genmodel.impl.GenModelImpl.reconcile(GenModelImpl.java:8591)
	at org.eclipse.emf.codegen.ecore.genmodel.presentation.GenModelEditor.initialize(GenModelEditor.java:594)
	at org.eclipse.emf.codegen.ecore.genmodel.presentation.GenModelEditor.createPages(GenModelEditor.java:1080)
	at org.eclipse.ui.part.MultiPageEditorPart.createPartControl(MultiPageEditorPart.java:348)
	at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:670)
	at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:465)
	at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:595)
	at org.eclipse.ui.internal.EditorReference.getEditor(EditorReference.java:289)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2863)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2768)
	at org.eclipse.ui.internal.WorkbenchPage.access$11(WorkbenchPage.java:2760)
	at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2711)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2707)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2691)
	at org.eclipse.ui.actions.OpenWithMenu.openEditor(OpenWithMenu.java:331)
	at org.eclipse.ui.actions.OpenWithMenu$2.handleEvent(OpenWithMenu.java:179)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1383)

My plugin correctly depends on the respective OCL plugins.

Reproducible: Always

Steps to Reproduce:
1. Reference the OCL and OCLEcore metamodels with usedGenPackages
2. Open the genmodel file in the "EMF Generator"
3. The editor crashes

Comment 1 Ed Merks

2010-10-18 08:44:44 EDT

I can't reproduce a problem with these usedGenPackage references.  I can't even reproduce a problem when I add references to packages that I know don't resolve.  The only way this could happen, apparently, is if you have GenPackages with null .getEcorePackage() so I added a guard for that.  Even with the guard, you'll be needing to fix whatever is bogus in your file, so don't expect fixes in a maintenance stream.

Comment 2 Ed Merks

2010-11-05 05:41:27 EDT

The fix is available in the latest build for the stream.