Bugzilla – Full Text Bug Listing
| Summary: | [sd90] Design user interface for new scanner discovery | ||
|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Andrew Gvozdev <angvoz.dev> |
| Component: | cdt-build | Assignee: | Andrew Gvozdev <angvoz.dev> |
| Status: | RESOLVED FIXED | QA Contact: | Andrew Gvozdev <angvoz.dev> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | cdtdoug, eclipse.sprigogin, malaperle, yevshif |
| Version: | 8.0 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 88402, 279502 | ||
| Bug Blocks: | 290631 | ||
|
Description
Andrew Gvozdev
This depends on the fate of patch bug 279502 comment 40 which is blocking the progress on this one. I placed my git repository on GitHub https://github.com/angvoz/SD80. Use branch [sd80] from the git repository for the bleeding edge version with more advanced UI or [sd80.Patch#.CDT] for clean version intended for submission. See also http://wiki.eclipse.org/CDT/ScannerDiscovery61/API. The branch for this bug is [sd80.Patch2.CDT]. It includes also the blocking changes bug 279502 comment 40. Hi Andrew, I tried the sd80 branch. The UI is nice! I have a couple of questions/comments. I see the Providers tab in both "Paths and Symbols" and "Providers (under construction)" on the left side. Do you intend to keep both? Maybe a link from Paths and Symbols would be enough? The "Configure/Show entries" button feels a bit weird IMO. It changes everything under tab when the button is clicked, maybe they should be two tabs at the top instead? Configuration and Entries? I think I encountered small bugs using the UI. You probably know about them though! -For GCC C++ Detector, when I checked "Use shared provider defined globally", it defaulted to "Activate on every build". But I couldn't change it in the workspace settings. -Buttons not working, things not getting disabled when unchecked... probably all WIP :) (In reply to comment #3) > Hi Andrew, I tried the sd80 branch. The UI is nice! I have a couple of > questions/comments. Thanks, the feedback especially the critical one is very much appreciated. > I see the Providers tab in both "Paths and Symbols" and "Providers (under > construction)" on the left side. Do you intend to keep both? Maybe a link from > Paths and Symbols would be enough? One of them was to prepare for clean CDT patch. Actually, I got rid of it yesterday. sd80 has only one now (corresponding to more advanced "under constructon" one). > The "Configure/Show entries" button feels a bit weird IMO. It changes everything > under tab when the button is clicked, maybe they should be two tabs at the top > instead? Configuration and Entries? Do you feel it's weird? I am unsure what is the best UI here. We can try 2 tabs. Well, if there are 2 tabs maybe I should move them to separate property page, separate from Paths&Symbols? I was looking at it for so long I am afraid I lost judgment on the UI front. > I think I encountered small bugs using the UI. You probably know about them > though! > -For GCC C++ Detector, when I checked "Use shared provider defined globally", it > defaulted to "Activate on every build". But I couldn't change it in the > workspace settings. > -Buttons not working, things not getting disabled when unchecked... probably all > WIP :) Yeah, workspace preference page is unfinished WIP. Property page is in much better shape, it should function OK. (In reply to comment #4) > (In reply to comment #3) > > The "Configure/Show entries" button feels a bit weird IMO. It changes > everything > > under tab when the button is clicked, maybe they should be two tabs at the top > > instead? Configuration and Entries? > Do you feel it's weird? I am unsure what is the best UI here. We can try 2 tabs. > Well, if there are 2 tabs maybe I should move them to separate property page, > separate from Paths&Symbols? I was looking at it for so long I am afraid I lost > judgment on the UI front. I put it into 2 tabs in separate page, want to see how it feels. Propagated current version of UI from sd90 to master. I suppose it's not ideal but on the other hand there shouldn't be much bugs. I'll do some improvements for Kepler, hopefully after some more feedback. I'll try the new version, sorry I should have given you more feedback after my first comment. Maybe wait for bug 376592 which will plug providers into new project wizard. I should be able to dispose it in a couple of days. *** cdt git genie on behalf of Andrew Gvozdev ***
bug 328007: [sd90] Disablement of property pages depending on preference
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=5edeb05a5b0fd3f3d31b26f73262cd9ad3cc9e1f
*** cdt git genie on behalf of Andrew Gvozdev ***
bug 328007: [sd90] Design user interface for new scanner discovery
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=2b5e3e6a20a411b4f000c0d9a4eb7a33813a628c
*** cdt git genie on behalf of Andrew Gvozdev ***
Merge: 5edeb05 0148ba9
bug 328007: [sd90] Design user interface for new scanner discovery
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=bd0b8b5ea8244d1a07857d613026c7595f8490f2
*** cdt git genie on behalf of Andrew Gvozdev ***
bug 328007: [sd90] Correction for "Restore Defaults"
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=8bf2dc8d1d985a1ca433b357f83a2bcf0f222803
*** cdt git genie on behalf of Andrew Gvozdev ***
bug 328007: [sd90] Decoration for non-existing providers
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=a45da7ed8a79a1b23741a9132f0ae06ddff74c12
|