Bug 327974

Comment 1 Simon Pope 2010-10-16 19:47:34 EDT

Fix for Mac is easy. Change all of the casts from double to float in getPathData(). Need to check if any other platforms exhibit this behavior or if it's an SWT-Cocoa anomaly.

Comment 2 Simon Pope 2010-10-16 19:48:07 EDT

Lack of sleep. Should have read: "Change all of the casts from *int* to float in
getPathData().

Comment 3 Simon Pope 2010-10-16 20:06:37 EDT

OK. Checked Win32 Platform. The points being cast to integers seems to be an anomaly of Cocoa (and maybe Carbon?). Upping importance to "Major" since it's a genuine loss of functionality for the Cocoa platform.

I recommend implementing the following change to getPathData():

	if (isDisposed()) SWT.error(SWT.ERROR_GRAPHIC_DISPOSED);
	NSAutoreleasePool pool = null;
	if (!NSThread.isMainThread()) pool = (NSAutoreleasePool) new NSAutoreleasePool().alloc().init();
	try {
		int count = (int)/*64*/handle.elementCount();
		int pointCount = 0, typeCount = 0;
		byte[] types = new byte[count];
		float[] pointArray = new float[count * 6];
		int /*long*/ points = OS.malloc(3 * NSPoint.sizeof);
		if (points == 0) SWT.error(SWT.ERROR_NO_HANDLES);
		NSPoint pt = new NSPoint();
		
		//TODO: Bug 327974 Change all casts from int to float
		for (int i = 0; i < count; i++) {
			int element = (int)/*64*/handle.elementAtIndex(i, points);
			switch (element) {
				case OS.NSMoveToBezierPathElement:
					types[typeCount++] = SWT.PATH_MOVE_TO;
					OS.memmove(pt, points, NSPoint.sizeof);
					pointArray[pointCount++] = (float)pt.x;
					pointArray[pointCount++] = (float)pt.y;
					break;
				case OS.NSLineToBezierPathElement:
					types[typeCount++] = SWT.PATH_LINE_TO;
					OS.memmove(pt, points, NSPoint.sizeof);
					pointArray[pointCount++] = (float)pt.x;
					pointArray[pointCount++] = (float)pt.y;
					break;
				case OS.NSCurveToBezierPathElement:
					types[typeCount++] = SWT.PATH_9CUBIC_TO;
					OS.memmove(pt, points, NSPoint.sizeof);
					pointArray[pointCount++] = (float)pt.x;
					pointArray[pointCount++] = (float)pt.y;
					OS.memmove(pt, points + NSPoint.sizeof, NSPoint.sizeof);
					pointArray[pointCount++] = (float)pt.x;
					pointArray[pointCount++] = (float)pt.y;
					OS.memmove(pt, points + NSPoint.sizeof + NSPoint.sizeof, NSPoin9t.sizeof);
					pointArray[pointCount++] = (float)pt.x;
					pointArray[pointCount++] = (float)pt.y;
					break;
				case OS.NSClosePathBezierPathElement:
					types[typeCount++] = SWT.PATH_CLOSE;
					break;
			}
		}
		OS.free(points);
		if (pointCount != pointArray.length) {
			float[] temp = new float[pointCount];
			System.arraycopy(pointArray, 0, temp, 0, pointCount);
			pointArray = temp;
		}
		PathData data = new PathData();
		data.types = types;
		data.points = pointArray;
		return data;
	} finally {
		if (pool != null)  pool.release();
	}
}

Comment 4 Simon Pope 2010-10-16 20:29:28 EDT

Created attachment 181041 [details]
Code fragment with corrected Path.getPathData()

OK, let's try that again (don't know where the '9's came from in the pasted code. Saved now as an attachment.

Comment 5 Scott Kovatch 2010-10-18 00:37:55 EDT

The fix looks okay. If you have a small test case or screen shot describing what you are seeing please attach it.

I can't see a reason not to check it in, but something showing the problem would be good.

Comment 6 Simon Pope 2010-10-18 01:23:13 EDT

Created attachment 181058 [details]
Screenshot of behvaior with points cast to int

Comment 7 Simon Pope 2010-10-18 01:23:53 EDT

Created attachment 181059 [details]
Screenshot of behavior after code correction

Comment 8 Scott Kovatch 2010-10-18 11:52:03 EDT

Okay, that's pretty compelling. :-) Fix coming shortly.

Comment 9 Scott Kovatch 2010-10-18 11:53:56 EDT

Fixed as described > 20100118. Thanks for the patch!