Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327911

Summary: Memory leak in TLDTagRegistry - need to remove preference store listener
Product: [WebTools] Java Server Faces Reporter: Carlin Rogers <carlin.rogers>
Component: JSF ToolsAssignee: Carlin Rogers <carlin.rogers>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cameron.bateman
Version: 3.2.2   
Target Milestone: 3.2.3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch ro remove listener none

Description Carlin Rogers CLA 2010-10-15 11:42:28 EDT 
When the TLDTagRegistry class is disposed, it needs to call removeListener() on the TLDRegistryPreferences so that the reference from the preference store is removed. Should also call dispose on the referenced TLDRegistryPreferences instance so additional memory/resources are released.
Comment 1 Carlin Rogers CLA 2010-10-15 13:08:10 EDT 
Created attachment 180990 [details]
patch ro remove listener
Comment 2 Cameron Bateman CLA 2010-10-15 14:48:48 EDT 
This looks good.
Comment 3 Carlin Rogers CLA 2010-10-15 16:12:26 EDT 
Thanks for the review Cameron. I committed the patch (in HEAD - revision 1.11 of TLDTagRegistry).