Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327775

Summary: ExternalSettingsProvider does not update existing macros
Product: [Tools] CDT Reporter: Marko Tomljenovic <marko.tomljenovic>
Component: cdt-coreAssignee: Project Inbox <cdt-core-inbox>
Status: RESOLVED WORKSFORME QA Contact: Doug Schaefer <cdtdoug>
Severity: major    
Priority: P3 CC: jamesblackburn+eclipse
Version: 7.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Discussion with cdt dev mailing list none

Description Marko Tomljenovic CLA 2010-10-14 09:34:17 EDT
Created attachment 180877 [details]
Discussion with cdt dev mailing list

When the externalSettingsProvider returns a macro that already exists but now has a different value, the new value is not taken.
Comment 1 James Blackburn CLA 2010-10-14 09:39:00 EDT
Are you able to add a test?
Comment 2 Marko Tomljenovic CLA 2010-10-15 03:25:47 EDT
I found the reason for my mentioned problem: 

I have been creating macros like this: new CMacroEntry("name", "value", ICSettingEntry.MACRO). When now updating the value through the ExternalSettingsProvider the new value is not taken, the last one is always kept.

When I create the macros like this: new CMacroEntry("name", "value", 0) then the new value is taken and shown properly.

Although I have used the wrong API calls I would expect another behaviour than what I described (initial value is taken, all newer values not).

I will attach the failing test for that soon.
Comment 3 Marko Tomljenovic CLA 2010-10-15 03:29:56 EDT
In the trunk the test won't fail so it seems the bug has been fixed there.

I think this issue can be closed.
Comment 4 James Blackburn CLA 2010-10-15 04:20:30 EDT
Ok, thanks for letting us know.