Bugzilla – Full Text Bug Listing
| Summary: | QVTo log writer gets strings instead of objects, making custom loggers useless/impossible | ||
|---|---|---|---|
| Product: | [Modeling] QVTo | Reporter: | Sergey Boyko <serg.boyko2011> |
| Component: | Engine | Assignee: | Sergey Boyko <serg.boyko2011> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | dh_tue |
| Version: | unspecified | ||
| Target Milestone: | 3.0 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
> Resolution: Behavior should be changed, so that the object itself is passed to
the logger.
Obviously, to keep the current behavior, the default logger should then do the same conversion to string...
Committed. > Committed.
Since it was committed, I expected it to be in Helios SR2. However, this does not seem to be the case. Will it not be included in official releases until Indigo?
(In reply to comment #3) It was my slip. I've committed changes to HEAD only so fix is available only with Indigo Mx builds. In case of necessity I can issue 3.0.1 maintenace build for Helios. > > Since it was committed, I expected it to be in Helios SR2. However, this does > not seem to be the case. Will it not be included in official releases until > Indigo? |
QVTo has a org.eclipse.m2m.qvt.oml.util.WriterLog class that implements org.eclipse.m2m.qvt.oml.util.Log. There is a: void log(String message, Object param); method in the interface. If I do this in QVTo: log("some message", someObj); I would expect that 'param' in the log method of the Log interface, would get the value of the object I provided (someObj in this case). However, the doVisitLogExp method of the org.eclipse.m2m.internal.qvt.oml.evaluator.QvtOperationalEvaluationVisitorImpl class (which calls the log method of the logger), uses the EvaluationUtil.formatLoggedElement method to convert the object to a string representation, before passing it along to the log method of the logger. This means that the log method of the logger (like the WriterLog class), always get strings instead of the objects. This also means I can't do anything custom to create different string representations for the objects being logged. That is, not without changing QVTo itself. Resolution: Behavior should be changed, so that the object itself is passed to the logger.