Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327712

Summary:

[build][hudson] add capability to disable hudson discovery

Product:

z_Archived

Reporter:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Component:

Mylyn

Assignee:

Torkild Resheim <torkildr>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

steffen.pingel, thomas.ehrnhoefer, torkildr

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

329897, 330064

Bug Blocks:

Attachments:

Description	Flags
Example screenshot	none
The correct screenshot	none
Patch to take advantage of improvements in service messaging	none
mylyn/context/zip	none

Description Thomas Ehrnhoefer

2010-10-13 17:01:03 EDT

while the auto discovery of hudson server is a great feature for some, for others it might be distracting. Would be good to have a way of disabling, at least a preference (also made accessible from the hudson view). Additionally the notification message for discovered server could have a link or checkbox for "never show messages like this" or something similar

Comment 1 Steffen Pingel

2010-10-26 04:10:16 EDT

Agreed, there should be a simple way to disable auto discovery.

Comment 2 Torkild Resheim

2010-10-26 14:18:36 EDT

I could look into that.

Comment 3 Torkild Resheim

2010-11-10 08:06:31 EST

It appears that the best way of handling this would be through the notifications mechanism. We could add a new icon on all service messages that when clicked would open the "General > Notifications" preference page on the appropriate item.

Comment 4 Torkild Resheim

2010-11-10 08:07:45 EST

Created attachment 182804 [details]
Example screenshot

Screenshot showing the configuration button.

Comment 5 Torkild Resheim

2010-11-10 08:09:27 EST

The implementation suggested in comment #3 would require changes to o.e.m.c.notifications. Any thoughts about this Steffen?

Comment 6 Torkild Resheim

2010-11-10 08:10:16 EST

Created attachment 182805 [details]
The correct screenshot

Comment 7 Steffen Pingel

2010-11-10 08:24:25 EST

+1 I like the icon. Should be fairly straight forward to make this work for the notifications framework. Please feel free to open a bug and attach a patch with the necessary changes.

Comment 8 Torkild Resheim

2010-11-10 08:49:38 EST

(In reply to comment #7)
> +1 I like the icon. Should be fairly straight forward to make this work for the
> notifications framework. Please feel free to open a bug and attach a patch with
> the necessary changes.
Done. See bug 329897. Note that this will not actually stop the discovery from taking place. I don't know if this mechanism is consuming a noticeable amount of resources and whether or not it's worthwhile to implementing another setting specific to Hudson discovery. This preference page would be placed in "Builds > Hudson" or something similar.

Comment 9 Torkild Resheim

2010-11-12 13:32:26 EST

Created attachment 183023 [details]
Patch to take advantage of improvements in service messaging

See bug 329897.

Comment 10 Torkild Resheim

2010-11-12 13:32:28 EST

Created attachment 183024 [details]
mylyn/context/zip

Comment 11 Torkild Resheim

2010-12-07 04:00:11 EST

Now I think we only need to apply the patch for bug 330064 and we can resolve this as fixed.

Comment 12 Torkild Resheim

2011-01-31 15:12:25 EST

As bug 330064 has been resolved I believe we have a working solution to this issue. Marking as resolved.