Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327672

Summary: [Net] Error: "Preference node "org.eclipse.core.net" has been removed."
Product: [Eclipse Project] Platform Reporter: Oleg Besedin <ob1.eclipse>
Component: TeamAssignee: Wojciech Galanciak <wojciech.galanciak>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: daniel_megert, markus.kell.r, Olivier_Thomann, wojciech.galanciak
Version: 3.7Flags: Szymon.Brandys: review+
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
fix
none
improved fix Szymon.Brandys: iplog+

Description Oleg Besedin CLA 2010-10-13 10:51:40 EDT
Using I20101012-0800, when importing a project set, the error log gets filled with stack traces like this:

java.lang.IllegalStateException: Preference node "org.eclipse.core.net" has been removed.
at org.eclipse.core.internal.preferences.EclipsePreferences.checkRemoved(EclipsePreferences.java:157)
at org.eclipse.core.internal.preferences.EclipsePreferences.internalGet(EclipsePreferences.java:513)
at org.eclipse.core.internal.preferences.EclipsePreferences.getBoolean(EclipsePreferences.java:372)
at org.eclipse.core.internal.net.PreferenceManager.migrateUpdateHttpProxy(PreferenceManager.java:314)
at org.eclipse.core.internal.net.PreferenceManager.migrateInstanceScopePreferences(PreferenceManager.java:266)
at org.eclipse.core.internal.net.ProxyManager.migrateInstanceScopePreferences(ProxyManager.java:407)
at org.eclipse.core.internal.net.PreferenceModifyListener.preApply(PreferenceModifyListener.java:27)
at org.eclipse.core.internal.preferences.PreferencesService$4.run(PreferencesService.java:449)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.preferences.PreferencesService.firePreApplyEvent(PreferencesService.java:452)
at org.eclipse.core.internal.preferences.PreferencesService.applyPreferences(PreferencesService.java:122)
at org.eclipse.core.internal.resources.ProjectPreferences.read(ProjectPreferences.java:234)
at org.eclipse.core.internal.resources.ProjectPreferences.updatePreferences(ProjectPreferences.java:302)
at org.eclipse.core.internal.resources.File.updateMetadataFiles(File.java:414)
at org.eclipse.core.internal.resources.File.internalSetContents(File.java:326)
at org.eclipse.core.internal.resources.File.create(File.java:163)
at org.eclipse.core.internal.resources.File.create(File.java:196)
at org.eclipse.team.internal.ccvs.core.resources.EclipseFile.setContents(EclipseFile.java:184)
at org.eclipse.team.internal.ccvs.core.client.Session.receiveFile(Session.java:801)
at org.eclipse.team.internal.ccvs.core.client.UpdatedHandler.receiveTargetFile(UpdatedHandler.java:119)
at org.eclipse.team.internal.ccvs.core.client.UpdatedHandler.handle(UpdatedHandler.java:100)
at org.eclipse.team.internal.ccvs.core.client.Request.executeRequest(Request.java:218)
at org.eclipse.team.internal.ccvs.core.client.Command.doExecute(Command.java:413)
at org.eclipse.team.internal.ccvs.core.client.Checkout.doExecute(Checkout.java:159)
at org.eclipse.team.internal.ccvs.core.client.CheckoutWithOverwrite.doExecute(CheckoutWithOverwrite.java:52)
at org.eclipse.team.internal.ccvs.core.client.Command$1.run(Command.java:326)
at org.eclipse.team.internal.ccvs.core.resources.EclipseSynchronizer.run(EclipseSynchronizer.java:1481)
at org.eclipse.team.internal.ccvs.core.resources.EclipseResource$2.run(EclipseResource.java:262)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1975)
at org.eclipse.team.internal.ccvs.core.resources.EclipseResource.run(EclipseResource.java:259)
at org.eclipse.team.internal.ccvs.core.client.Command.execute(Command.java:338)
at org.eclipse.team.internal.ccvs.ui.operations.CheckoutProjectOperation.performCheckout(CheckoutProjectOperation.java:272)
at org.eclipse.team.internal.ccvs.ui.operations.CheckoutProjectOperation$2.run(CheckoutProjectOperation.java:171)
at org.eclipse.team.internal.ccvs.core.resources.EclipseSynchronizer.run(EclipseSynchronizer.java:1481)
at org.eclipse.team.internal.ccvs.ui.operations.CheckoutProjectOperation.checkout(CheckoutProjectOperation.java:169)
at org.eclipse.team.internal.ccvs.ui.operations.CheckoutMultipleProjectsOperation.checkout(CheckoutMultipleProjectsOperation.java:58)
at org.eclipse.team.internal.ccvs.ui.operations.CheckoutOperation.checkout(CheckoutOperation.java:47)
at org.eclipse.team.internal.ccvs.ui.operations.CheckoutOperation.execute(CheckoutOperation.java:32)
at org.eclipse.team.internal.ccvs.ui.operations.CVSOperation.run(CVSOperation.java:79)
at org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnableContext.java:144)
at org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.runInWorkspace(JobRunnableContext.java:72)
at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 Wojciech Galanciak CLA 2010-10-13 12:41:00 EDT
Created attachment 180791 [details]
fix

I can reproduce this issue when I import preferences a second time. When I import preferences to Eclipse with a clean configuration, first import is passed without this exception. I have attached a fix.
Comment 2 Wojciech Galanciak CLA 2010-10-13 13:53:20 EDT
Created attachment 180805 [details]
improved fix
Comment 3 Dani Megert CLA 2010-10-19 08:52:38 EDT
I get this with these simple steps:

1. start new workspace
2. check out a project from CVS

Caused by bad fix for bug 242057.

Setting to 'major' since "Preference node "org.eclipse.core.net" has been removed" sounds scary.
Comment 4 Wojciech Galanciak CLA 2010-10-20 05:48:00 EDT
Yes, you are right that it sounds scary :). Anyway, I have attached fix for this bug and now it is waiting for Szymon's review.
Comment 5 Olivier Thomann CLA 2010-10-20 09:11:32 EDT
I also got it checking out from CVS WTP bundles.
Comment 6 Szymon Brandys CLA 2010-10-25 10:30:09 EDT
Released in HEAD.