Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327661

Summary: Several about.html have invalid hyperlinks to local copy of license
Product: [Tools] Orbit Reporter: Martin Oberhuber <mober.at+eclipse>
Component: bundlesAssignee: Martin Oberhuber <mober.at+eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: caniszczyk, david_williams
Version: unspecified   
Target Milestone: Indigo M4   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 329432    
Bug Blocks: 332005, 327662, 327663    
Attachments:
Description Flags
Shellscript to find all 3rd party licenses in a local install none

Description Martin Oberhuber CLA 2010-10-13 09:30:22 EDT
Created attachment 180765 [details]
Shellscript to find all 3rd party licenses in a local install

Build ID: Helios SR1

When mining about.html files, I found the following (non-exhaustive) list of about.html files which have broken hyperlinks to the local copy of a 3rd party license. Each of the "filename not matched" below refers to an <a href="..."> statement in about.html which is not matched by an actual file in the plugin.

In most cases, the link is broken due to a case mismatch ('.txt' vs '.TXT' or missing file extension, sometimes a completely different name. I think that respective about.html's should be fixed.

---Orbit---
org.apache.commons.httpclient_3.1.0.v201005080502.jar : about.html
  caution: filename not matched:  about_files/NOTICE.txt

org.apache.xerces_2.9.0.v201005080400.jar : about.html
  caution: filename not matched:  about_files/LICENSE.txt
  caution: filename not matched:  about_files/NOTICE-Xerces-J
  caution: filename not matched:  about_files/NOTICE-xml-apis

---Equinox---
org.eclipse.equinox.registry_3.5.0.v20100503.jar : about.html
  caution: filename not matched:  about_files/NOTICE.TXT

org.eclipse.equinox.p2.updatesite_1.0.201.R36x_v20100823.jar : about.html
  caution: filename not matched:  about_files/NOTICE.TXT

org.eclipse.equinox.ds_1.2.1.R36x_v20100803.jar : about.html
  caution: filename not matched:  about_files/NOTICE.TXT
  

I'm attaching my (arguably quite hacked) shellscript by which I found those culprits. Interesting is the grep..sed combination to read the href from about.html. It may be interesting to apply a similar shellscript to the Orbit releng tests, or, on a larger scale, to the Indigo releng code such that broken hyperlinks are found in the future.

I'm going to clone a separate bug for the Equinox culprits.
Comment 1 DJ Houghton CLA 2010-11-18 14:05:13 EST
Adding David to CC to address Xerces issue.
Adding Chris to CC to address HTTPClient issue.
Comment 2 Martin Oberhuber CLA 2010-12-07 07:07:17 EST
The concrete culprits mentioned in this bug have been fixed.

I have filed bug 332005 as a follow-up to improve Orbit releng, such that broken hyperlinks are found in the future.

I don't know whether the fixes here should be backported for Helios SR2 ?