Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327653

Summary: [Dialogs] FilteredItemsSelectionDialog burns a lot of time in LinkedList#contains(..)
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert
Version: 3.7Keywords: performance
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Fix none

Description Markus Keller CLA 2010-10-13 08:14:28 EDT 
Created attachment 180758 [details]
Fix

I20101012-0800

FilteredItemsSelectionDialog burns a lot of time in LinkedList#contains(..). This is mostly visible in real-life scenarios where e.g. Open Type has a full history (60 elements) and there are many matches.

In my runtime workspace (with a lot of garbage projects and a filled type history), this brings the match calculation time for "**" from 3.5s down to 0.7s.
Comment 1 Markus Keller CLA 2010-10-13 08:14:58 EDT 
Fixed in HEAD.
Comment 2 Markus Keller CLA 2010-12-07 11:53:15 EST 
Verified in I20101206-1800.
Comment 3 Dani Megert CLA 2011-10-06 03:50:11 EDT 
This didn't make it into the 4.x stream. Cherry-picked now:
Commit 74f04c211a0e6ad9851fd92ea3451501ddf011ff