Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327607

Summary:

Retrieving feature.xml needs to generate fetch factory specific Targets

Product:

[Eclipse Project] PDE

Reporter:

Andrew Niefer <aniefer>

Component:

Build

Assignee:

pde-build-inbox <pde-build-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

gunnar, pwebster

Version:

3.6

Target Milestone:

3.7 M3

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

289838

Attachments:

Description	Flags
patch	none

Description Andrew Niefer

2010-10-12 15:48:06 EDT

During fetch script generation, PDE/Build generates a script to fetch the feature.xml and then runs it in a nested ant.

The IFetchFactory interface provides IFetchFactory#addTargets(IAntScript) which allows fetch implementations to generate extra targets that may be needed by individual retrieve element calls.

We generating the nested script to get the feature.xml, we are not calling #addTargets so the resulting script may not work for some fetch factories.

Comment 1 Gunnar Wagenknecht

2010-10-13 03:37:43 EDT

BTW, the patch in bug 289838 already adds the necessary call to FetchScriptGenerator.

Comment 2 Andrew Niefer

2010-10-13 10:46:16 EDT

Created attachment 180773 [details]
patch

This is the patch I used, here we are generating a script that fetches one feature.xml there is only one factory involved so we don't need to loop

Comment 3 Andrew Niefer

2010-10-13 10:47:13 EDT