Bugzilla – Full Text Bug Listing
| Summary: | Commands, Handlers, and keybindings should use leaf lookup | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Paul Webster <pwebster> | ||||||||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | ob1.eclipse, remy.suen | ||||||||||
| Version: | unspecified | ||||||||||||
| Target Milestone: | 4.1 M3 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 180695 [details]
Allow the eclipse context v01
This is a naive implementation. It simply allows all suppliers to set the IEclispeContext. In our cases, the primary supplier would set it (since it runs after the temp supplier).
It does allow the temp supplier to set it in the case that primary supplier == null.
Oleg, does this look reasonable?
PW
Created attachment 180701 [details]
Use active leaf v02
I've included my change to the core.di stuff, but just as a temporary workaround until Oleg can consider the problem.
PW
Created attachment 180702 [details]
Updated "Allow the eclipse context v01"
Very nicely done, I'll change JUnits a bit as well.
(In reply to comment #2) > Created an attachment (id=180701) [details] > Use active leaf v02 I'll hold off on my patch to core.di, then :-) PW Released. It looks OK, although there may still be some minor compatibility layer work. PW |
Created attachment 180689 [details] Use active leaf v01 The command, handler, and binding service should use the activeLeaf() lookup when it's time to execute. PW