Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327565

Summary: JSP discoverer : duplicate scriptlet content leads to unnecessary memory usage
Product: [Modeling] MoDisco Reporter: Fabien Giquel <fabien.giquel>
Component: TechnologiesAssignee: Fabien Giquel <fabien.giquel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hugo.bruneliere, modisco.web-inbox
Version: 0.9.0Flags: fabien.giquel: indigo+
Target Milestone: 0.9.0 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
JSP discoverer memory usage improvment fabien.giquel: iplog+

Description Fabien Giquel CLA 2010-10-12 10:55:49 EDT 
Parsing some JSP with JSP scriptlet leads to JSPScriptlet instances where content is both attached to the "name" attribute and a child Text instance.

The content should be contained only on child Text instance.
Comment 1 Nicolas Guyomar CLA 2010-10-12 12:04:04 EDT 
Created attachment 180685 [details]
JSP discoverer memory usage improvment

Hi Fabien,

In order to reduce the memory usage the MoDisco Jsp Discoverer does no longer store a name for the JSPScript (Sriptlet, Expression and Declaration)

In order to keep the visualization in the model browser intact I created a query to complete the existing uiCustomization for MoDisco JSP Models.

(a) I, Nicolas Guyomar, wrote 100% of the code of the contribution
(b) I have the right to contribute the code to Eclipse
(c) I want to contribute this code under EPL


Regards

Nicolas Guyomar
Comment 2 Fabien Giquel CLA 2010-10-14 03:47:56 EDT 
The contribution is less than 250 lines.
It has been commited into SVN (rev 3323)

Fabien.
Comment 3 Hugo Bruneliere CLA 2010-10-21 05:03:11 EDT 
The patch has been successfully integrated.