Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327500

Summary:	Implement Methods doesn't seem to work
Product:	[Tools] CDT	Reporter:	Doug Schaefer <cdtdoug>
Component:	cdt-core	Assignee:	Project Inbox <cdt-core-inbox>
Status:	NEW ---	QA Contact:	Jonah Graham <jonah>
Severity:	normal
Priority:	P3	CC:	malaperle, yevshif
Version:	7.0.1
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Doug Schaefer

2010-10-12 00:07:01 EDT

I'm porting the Irrlicht rendering library to Android. As I started implementing an archive loader, I tried using the Source->Implement Methods feature. I first tried in the class definition in hoping it would populate my class with the pure virtual methods from the super class but that didn't happen. Later, after manually entering the methods into my class, I tried using it to provide skeleton implementations for those methods using Implement Methods. It still provided nothing.

I'm not sure how this feature is supposed to work or if it's working at all.

Comment 1 Marc-André Laperle

2010-10-12 00:23:27 EDT

Hi Doug,

"I tried using it to provide skeleton implementations for those methods using Implement Methods."

This is what it should do. It doesn't do "override method" at this time. Do you have anything in the error log? Can you provide a sample where it doesn't work? There are a couple of bugs opened for implement method, but this could be a different one.

Comment 2 Doug Schaefer

2010-10-12 10:26:47 EDT

Nothing in the error log.

But it is a sign that these C++ accelerators need some love.

Comment 3 Marc-André Laperle

2010-10-12 13:02:45 EDT

(In reply to comment #2)
> Nothing in the error log.
> 
> But it is a sign that these C++ accelerators need some love.

I want to give it some love but I need to reproduce it first. I can generate the implementations for this class. The namespaces are not added but I still generates implementations.

#ifndef TESTARCHIVELOADER_H_
#define TESTARCHIVELOADER_H_

#include "IFileSystem.h"

namespace irr
{
namespace io
{
class TestArchiveLoader : public IArchiveLoader {
	virtual bool isALoadableFileFormat(const path& filename) const;
	virtual bool isALoadableFileFormat(io::IReadFile* file) const;
	virtual bool isALoadableFileFormat(E_FILE_ARCHIVE_TYPE fileType) const;

	virtual IFileArchive* createArchive(const path& filename, bool ignoreCase, bool ignorePaths) const;
	virtual IFileArchive* createArchive(io::IReadFile* file, bool ignoreCase, bool ignorePaths) const;
};
}
}

#endif

BTW, I worked on several patches related to implement method, but they need some committer love. See bug 292851, bug 317686 and bug 273525.