Bugzilla – Full Text Bug Listing
| Summary: | add IMemory.ErrorOffset RANGE_KEY_XXXX static strings for use by MemoryProxy, etc | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] TCF | Reporter: | Kirk Beitz <kirk.beitz> | ||||
| Component: | Core | Assignee: | Project Inbox <dsdp.tm.tcf-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | cdtdoug, eugene | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 0.4.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 180628 [details]
simple patch to supply RANGE_KEY_XXXX strings for use in constructing the ranges passed in IMemory.ErrorOffset reports
attached is a simple patch for what i would like to be able to use from TCF
The patch looks fine. Committed. Thanks! Moving bugs to new home for IP log. Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3 |
Build Identifier: private class MemoryProxy.MemoryErrorReport makes use of several strings ("addr", "size", "stat", "msg") in interpreting an error report for getMemory() call where the range may be broken into valid and invalid ranges. i recommend using static strings for these range keys, of the form RANGE_KEY_ADDR, etc. this would be in conforming with other static string use in the same interface, and would make it clearer in agents in which such strings are being constructed where the values are coming from, and (using eclipse ctrl-shift-g in the workspace) where they are used so that the proper construction can be made. Reproducible: Always