Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327330

Summary: More compact test result messages (links)
Product: [Eclipse Project] Platform Reporter: DJ Houghton <dj.houghton>
Component: RelengAssignee: Kim Moir <kim.moir>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, kim.moir, markus.kell.r, Olivier_Thomann
Version: 3.7   
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
patch none

Description DJ Houghton CLA 2010-10-08 08:26:44 EDT
We talked about this briefly but I wanted to enter a bug so we didn't lose track. 

The new test result emails are nice because they have direct links to the test failures. Currently the messages look like:

org.eclipse.equinox.p2.tests_linux.gtk.x86_6.0

 http://download.eclipse.org/eclipse/downloads/drops/N20101007-2000/testresults/xml/org.eclipse.equinox.p2.tests_linux.gtk.x86_6.0.xml

Would it be possible to change them so you only see a line for the failed test component/platform and then the link would take you to the specific failure page?

Or is this a problem because some people view the msg as plain text? (note they would still get the link to the main download page) 

Also, if this change is made, are you still able to drag and drop the link to the JUnit view to display results as per John's msg? [1]

[1] http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg17503.html
Comment 1 John Arthorne CLA 2010-10-08 09:34:20 EDT
See also recent comments in bug 296009
Comment 2 Markus Keller CLA 2010-10-08 09:58:44 EDT
(In reply to comment #0)
> Also, if this change is made, are you still able to drag and drop the link to
> the JUnit view to display results as per John's msg? [1]

That depends on your Email client. If it's correctly implemented (e.g. Thunderbird 3.1.4), then it works with HTML as well as with plain text messages. Other clients like Lotus Notes 8.5.2 don't support drag-and-drop of links, so it doesn't work nicely with either format. The only way I found to make it work in Notes is by selecting the full link in a plain text message and then dragging the text selection.


(From bug 296009 comment #9)
Same here. I find that list quite hard to parse. Even when viewing full-screen,
it looks like this:

org.eclipse.jdt.ui.tests_linux.gtk.x86_6.0
             http://down.../org.eclipse.jdt.ui.tests_linux.gtk.x86_6.0.xml
org.eclipse.jdt.ui.tests_macosx.cocoa.x86_5.0
             http://down.../org.eclipse.jdt.ui.tests_macosx.cocoa.x86_5.0.xml

Unfortunately, HTML links cannot be drag-and-dropped in all Email clients, so I guess the best compromise is to keep the original list of failing tests, followed by a list of links, i.e.:

org.eclipse.jdt.ui.tests_linux.gtk.x86_6.0
org.eclipse.jdt.ui.tests_macosx.cocoa.x86_5.0

http://down.../org.eclipse.jdt.ui.tests_linux.gtk.x86_6.0.xml
http://down.../org.eclipse.jdt.ui.tests_macosx.cocoa.x86_5.0.xml

This would still allow me to see at a glance whether our tests are affected.
Comment 3 Markus Keller CLA 2010-10-08 10:05:45 EDT
Or even better:

org.eclipse.jdt.ui.tests_linux.gtk.x86_6.0
org.eclipse.jdt.ui.tests_macosx.cocoa.x86_5.0

HTTP Download:

http://download.eclipse.org/eclipse/downloads/drops/N20101005-2000 


Test result files (hint: drag and drop these to the JUnit view):

http://download.eclipse.org/eclipse/downloads/drops/N20101005-2000/testresults/xml/org.eclipse.jdt.ui.tests_linux.gtk.x86_6.0.xml
http://download.eclipse.org/eclipse/downloads/drops/N20101005-2000/testresults/xml/org.eclipse.jdt.ui.tests_macosx.cocoa.x86_5.0.xml
Comment 4 Markus Keller CLA 2010-10-08 11:18:47 EDT
> Test result files (hint: drag and drop these to the JUnit view):

With bug 327219 fixed, that should now read:
> Test result files (hint: copy/paste or drag-and-drop to the JUnit view):
Comment 5 Kim Moir CLA 2010-10-08 11:30:53 EDT
The new message looks like this with the fixes to the build. 

Build N20101007-2000 (Timestamp: 201010072000):  Automated JUnit testing is complete.  Test failures/errors occurred in the following:  

org.eclipse.equinox.p2.tests_linux.gtk.x86_6.0
org.eclipse.equinox.p2.tests_macosx.cocoa.x86_5.0
org.eclipse.equinox.p2.tests_win32.win32.x86_6.0


HTTP Download:

http://download.eclipse.org/eclipse/downloads/drops/N20101007-2000 


Test result files (hint: copy/paste or drag-and-drop to the JUnit view): 

http://download.eclipse.org/eclipse/downloads/drops/N20101007-2000/testresults/xml/org.eclipse.equinox.p2.tests_linux.gtk.x86_6.0.xml
http://download.eclipse.org/eclipse/downloads/drops/N20101007-2000/testresults/xml/org.eclipse.equinox.p2.tests_macosx.cocoa.x86_5.0.xml
http://download.eclipse.org/eclipse/downloads/drops/N20101007-2000/testresults/xml/org.eclipse.equinox.p2.tests_win32.win32.x86_6.0.xml
Comment 6 Kim Moir CLA 2010-10-08 11:34:26 EDT
Created attachment 180496 [details]
patch 

The code that generates the build messages is really ugly but it will go away when we switch to Hudson because it has email generation enabled natively.  Anyways, this fixes the message for now.
Comment 7 Kim Moir CLA 2010-10-08 11:34:54 EDT
closing
Comment 8 Markus Keller CLA 2010-10-11 08:55:34 EDT
The email for N20101010-2000 looks good.