Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327278

Summary:

Hitting a breakpoint during a step causes debug buttons to disable

Product:

[WebTools] JSDT

Reporter:

Michael Rennie <Michael_Rennie>

Component:

Debug

Assignee:

Michael Rennie <Michael_Rennie>

Status:

RESOLVED FIXED

QA Contact:

Simon Kaegi <simon_kaegi>

Severity:

normal

Priority:

CC:

ccc, Michael_Rennie, simon_kaegi, thatnitind

Version:

3.2

Flags:

thatnitind: review+

Target Milestone:

3.2.2 P

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

326809, 327270

Bug Blocks:

Attachments:

Description	Flags
fix	none

Description Michael Rennie

2010-10-07 16:13:11 EDT

+++ This bug was initially created as a clone of Bug #327270 +++

code from HEAD

debug the following snippet:

function Func(fval){
    this.__defineSetter__("value", function(val){
        value = val;  //bp here
    });
}

var myfunc = new Func("foo"); //bp here
myfunc.value = "foo2";

and step over until you hit the breakpoint in __defineSetter__. Notice that all of the debugging buttons (step over / into / out) are all disabled.

Taking a quick look revealed that we still think we are stepping in this case, so when the commands poll for enablement (canStep) we say no.

We should be handling the case of hitting a breakpoint while stepping - we already handle resuming while stepping.

Comment 1 Michael Rennie

2010-10-07 16:13:47 EDT

this clone is targetted for 3.2.2 patches

Comment 2 Michael Rennie

2010-10-07 16:17:08 EDT

Created attachment 180451 [details]
fix

The patch from bug 327270 also applies + resolves this issue

Comment 3 Carl Anderson

2010-10-11 17:18:38 EDT

Committed to R3_2_2_patches