Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327238

Summary:	Close All doesn't work when there is a view in the editor stack
Product:	[Eclipse Project] e4	Reporter:	John Arthorne <john.arthorne>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	remy.suen
Version:	1.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	321864

Description John Arthorne

2010-10-07 10:21:32 EDT

Comment 1 John Arthorne

2010-10-07 10:23:02 EDT

Build: 4.1 M2

Open a view and drag it into the editor stack (I used Console)
Open some editors
Hit Ctrl+Shift+W

One editor closes, and then the view becomes active and nothing else is closed. I would expect all editors to close but the view to stay open.

Comment 2 Remy Suen

2010-10-07 10:50:38 EDT

This would be our friendly scenario K from bug 321864.

Comment 3 Remy Suen

2010-11-01 15:34:10 EDT

To be clear, the 'Close All' command is meant to "Close all editors". This behaviour should not change.

We should instead create a new command in 4.x that is mapped to Ctrl+Shift+W (therein removing the binding from the original 'Close All' command in 3.x) that will close all parts within the shared area.

Comment 4 John Arthorne

2010-11-01 15:54:44 EDT

Personally I would be happy if Ctrl+Shift+W continued to close all editors. I don't know how useful a "Close all parts in the shared part area" command would be.

Comment 5 Remy Suen

2010-11-01 16:00:46 EDT

(In reply to comment #1)
> One editor closes, and then the view becomes active and nothing else is closed.
> I would expect all editors to close but the view to stay open.

Mm, looks like I misread your original concern, I'll investigate this to see what's going on here.

Comment 6 Remy Suen

2010-11-01 16:04:31 EDT

I don't think your original concern is a problem anymore, John. I cannot reproduce the bug on I20101029-1118.

Comment 7 John Arthorne

2010-11-01 16:13:43 EDT

Feel free to close then - I don't have a 4.1 build up a the moment.

Comment 8 Remy Suen

2010-11-02 09:10:52 EDT

I tried again on a fresh unzip of I20101029-1118 and could not reproduce the problem. Please do not hesitate to reopen the bug if it happens for you again, John.