Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327200

Summary:	Diff-Window opens in background
Product:	[Technology] EGit	Reporter:	leif.bladt
Component:	UI	Assignee:	Jens Baumgart <jens.baumgart>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	robin.rosenberg, stefan.lay
Version:	0.10.0
Target Milestone:	---
Hardware:	Macintosh
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description leif.bladt

2010-10-07 05:40:03 EDT

When I open the diff dialog with a double-click from the commit dialog, it sometimes happens that this dialog is opened behind the commit dialog.

The most annoying part is, that when I close the diff window, the commit dialog is "hidden". I need to use Expose (on OS X) the get back.

Unfortunately this happens not all the time and I don't have a clue, what triggers this behavior.

Comment 1 Jens Baumgart

2010-10-27 04:14:42 EDT

- Code looks ok. Parent widget of diff window is the active workbench window.
- Could not reproduce the problem both on Windows 7 and Mac.

Comment 2 leif.bladt

2010-10-27 04:59:32 EDT

(In reply to comment #1)
> - Code looks ok. Parent widget of diff window is the active workbench window.
> - Could not reproduce the problem both on Windows 7 and Mac.
Hmm,  with the newest nightly build (EGit 0.10.0.201010261520), this still occurs. What I did is:
 - Right-click on the project name
 - Team -> Commit...
 - Double-click on a modified file

Sometimes the compare window opens behind the commit window. Interestingly this depends on the commit dialog "session": Either all compare windows are opened in the background or all are opened correctly.

What other information could be useful to narrow this problem down?

Comment 3 Jens Baumgart

2010-10-27 10:43:37 EDT

(In reply to comment #1)
> - Code looks ok. Parent widget of diff window is the active workbench window.
> - Could not reproduce the problem both on Windows 7 and Mac.

This is not correct.

org.eclipse.compare.CompareUI.openCompareDialog
always uses the active workbench window as parent. But the parent should be
the commit dialog. So we have the window hierarchy

Workbench Window
  |____Commit Dialog
  |____Compare Dialog

and it's not clearly defined which hwindow should be on top.

Comment 4 Robin Rosenberg

2013-05-04 16:38:05 EDT

Closed due to being too old to investigate.