Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327156

Summary:

Formatting successive comments can condense them to the same line

Product:

[WebTools] WTP Source Editing

Reporter:

Nick Sandonato <nsand.dev>

Component:

wst.css

Assignee:

Nick Sandonato <nsand.dev>

Status:

RESOLVED FIXED

QA Contact:

Nick Sandonato <nsand.dev>

Severity:

normal

Priority:

CC:

thatnitind

Version:

3.2.2

Flags:

thatnitind: review+

Target Milestone:

3.2.3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none
patch	none

Description Nick Sandonato

2010-10-06 15:06:29 EDT

Successive comments can be concatenated onto the same line if they do not exceed the line width. This can cause frustration when the comments formatting is important.

Example:

/*****************************************
* Copyright...
*********/

/****

Version 1.0

******/

Can turn into

/*****************************************
* Copyright...
*********/ /****

Version 1.0

******/

Comment 1 Nick Sandonato

2010-10-06 15:08:32 EDT

Created attachment 180367 [details]
patch

This patch also makes it so that multiple blank lines will condense to one blank line instead of none.

Comment 2 Nick Sandonato

2010-10-07 10:37:25 EDT

Created attachment 180428 [details]
patch

Patch needed to include some work from Bug 259154.

Comment 3 Nick Sandonato

2010-10-07 10:40:23 EDT

Added new unit tests and also had to update some old ones. It appears that the code path would always insert two spaces between a } and /* */ on the same line. Corrected that issue and also fixed the unit tests that accounted for the two spaces.

Comment 4 Nick Sandonato

2010-10-19 17:16:57 EDT

Changes released to 3_2_Maintenance and HEAD.